base::Bind: Convert StreamSocket::Connect.

base::Bind: Convert StreamSocket::Connect.

BUG=none
TEST=none
R=csilv

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113283

[csilv, 2011-12-06 21:03:18]

http://codereview.chromium.org/8801004/diff/49/jingle/notifier/base/proxy_res...
File jingle/notifier/base/proxy_resolving_client_socket.cc (right):

http://codereview.chromium.org/8801004/diff/49/jingle/notifier/base/proxy_res...
jingle/notifier/base/proxy_resolving_client_socket.cc:100:
DCHECK(!old_user_connect_callback_);
Perhaps this DCHECK should be the same as the one on line 128?

http://codereview.chromium.org/8801004/diff/49/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/socket_test_util.cc...
net/socket/socket_test_util.cc:722: int result) {
nit: align parameters

http://codereview.chromium.org/8801004/diff/49/net/socket/socks5_client_socke...
File net/socket/socks5_client_socket.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/socks5_client_socke...
net/socket/socks5_client_socket.cc:71: DCHECK(!old_user_callback_);
make this same as line 94

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_n...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_n...
net/socket/ssl_client_socket_nss.cc:572: DCHECK(!old_user_connect_callback_);
make this check same as line 620

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_w...
File net/socket/ssl_client_socket_win.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_w...
net/socket/ssl_client_socket_win.cc:566: DCHECK(!old_user_connect_callback_);
make this check match line 589

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
File net/socket/tcp_client_socket_libevent.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
net/socket/tcp_client_socket_libevent.cc:508: DCHECK(!old_write_callback_);
also check write_callback here?

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
File net/socket/tcp_client_socket_libevent.h (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
net/socket/tcp_client_socket_libevent.h:111: } else if
(socket_->old_write_callback_) {
seems like we should also check write_callback?

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_w...
File net/socket/tcp_client_socket_win.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_w...
net/socket/tcp_client_socket_win.cc:712: DCHECK(!old_read_callback_);
also check for read_callback here?

http://codereview.chromium.org/8801004/diff/49/remoting/protocol/pepper_trans...
File remoting/protocol/pepper_transport_socket_adapter.cc (right):

http://codereview.chromium.org/8801004/diff/49/remoting/protocol/pepper_trans...
remoting/protocol/pepper_transport_socket_adapter.cc:126: int
PepperTransportSocketAdapter::Connect(net::OldCompletionCallback* callback) {
nit: wrap line to 80 cols

[James Hawkins, 2011-12-06 22:19:30]

http://codereview.chromium.org/8801004/diff/49/jingle/notifier/base/proxy_res...
File jingle/notifier/base/proxy_resolving_client_socket.cc (right):

http://codereview.chromium.org/8801004/diff/49/jingle/notifier/base/proxy_res...
jingle/notifier/base/proxy_resolving_client_socket.cc:100:
DCHECK(!old_user_connect_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> Perhaps this DCHECK should be the same as the one on line 128?

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/socket_test_util.cc...
net/socket/socket_test_util.cc:722: int result) {
On 2011/12/06 21:03:18, csilv wrote:
> nit: align parameters

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/socks5_client_socke...
File net/socket/socks5_client_socket.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/socks5_client_socke...
net/socket/socks5_client_socket.cc:71: DCHECK(!old_user_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> make this same as line 94

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_n...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_n...
net/socket/ssl_client_socket_nss.cc:572: DCHECK(!old_user_connect_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> make this check same as line 620

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_w...
File net/socket/ssl_client_socket_win.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/ssl_client_socket_w...
net/socket/ssl_client_socket_win.cc:566: DCHECK(!old_user_connect_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> make this check match line 589

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
File net/socket/tcp_client_socket_libevent.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
net/socket/tcp_client_socket_libevent.cc:508: DCHECK(!old_write_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> also check write_callback here?

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
File net/socket/tcp_client_socket_libevent.h (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_l...
net/socket/tcp_client_socket_libevent.h:111: } else if
(socket_->old_write_callback_) {
On 2011/12/06 21:03:18, csilv wrote:
> seems like we should also check write_callback?

Done.

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_w...
File net/socket/tcp_client_socket_win.cc (right):

http://codereview.chromium.org/8801004/diff/49/net/socket/tcp_client_socket_w...
net/socket/tcp_client_socket_win.cc:712: DCHECK(!old_read_callback_);
On 2011/12/06 21:03:18, csilv wrote:
> also check for read_callback here?

Done.

http://codereview.chromium.org/8801004/diff/49/remoting/protocol/pepper_trans...
File remoting/protocol/pepper_transport_socket_adapter.cc (right):

http://codereview.chromium.org/8801004/diff/49/remoting/protocol/pepper_trans...
remoting/protocol/pepper_transport_socket_adapter.cc:126: int
PepperTransportSocketAdapter::Connect(net::OldCompletionCallback* callback) {
On 2011/12/06 21:03:18, csilv wrote:
> nit: wrap line to 80 cols

Done.

[csilv, 2011-12-06 22:56:09]

lgtm