Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8905027: Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only initialize the num... (Closed)

Created:
9 years ago by Vangelis Kokkevis
Modified:
9 years ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only initialize the number of levels requirested. Also ClearLevel now uses glTexSubImage2D to clear the level if the texture is immutable. Finally, rearranged the code in doTexSubImage2D to correctly bypass clearing a level if the bitmaps supplied matches the dimensions of the texture level. BUG=106894 Review URL: http://codereview.chromium.org/8872061 Reverting as it may be causing a failure in the XP perf bots: http://build.chromium.org/p/chromium.perf/builders/XP%20Perf%20%28dbg%29/builds/6854 [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -70 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 8 chunks +32 lines, -48 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 2 chunks +2 lines, -3 lines 0 comments Download
MM gpu/command_buffer/service/texture_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM gpu/command_buffer/service/texture_manager.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vangelis Kokkevis
9 years ago (2011-12-13 00:50:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698