cc: Split ReleaseResources into Release and Recreate.

cc: Split ReleaseResources into Release and Recreate.

This patch splits the work we do in ReleaseResources into two parts:
ReleaseResources and RecreateResources. If any part of invalidating or
creating new resources requires access to new structures (such as a new
tile manager and new output surface), this is the way to get this
information.

That is, ReleaseResources happens while old objects are alive and
accessible. RecreateResources happens when the new objects are alive and
accessible.

R=danakj, enne

Committed: https://crrev.com/9ce5c6661b03f26326f4e5c50924a628eb638afa
Cr-Commit-Position: refs/heads/master@{#314913}

[vmpstr, 2015-02-05 20:35:35]

Please take a look. This is split up from
https://codereview.chromium.org/900073003/

[enne (OOO), 2015-02-05 20:43:52]

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:2216: ScopedCaller<LayerTreeHostImpl>
scoped_release_resources(
This seems like overkill.  Neither of the functions this is in has an early out,
so maybe just call the two functions you need?

Also, this is only valid for picture layers, so maybe DestroyTileManager and
CreateAndSetTileManager could just make these recreate/release calls?

[danakj, 2015-02-05 20:45:49]

what enne said :D

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:120: class ScopedCaller {
did you look around in base/ for something like this btw? maybe there is
something.. tho it'd probably use Callback.

[vmpstr, 2015-02-05 21:41:32]

PTAL

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:120: class ScopedCaller {
On 2015/02/05 20:45:49, danakj wrote:
> did you look around in base/ for something like this btw? maybe there is
> something.. tho it'd probably use Callback.

I couldn't really find anything that would do a similar thing. The closest is
ScopedClosureRunner, but it just runs a given closure in the dtor.

https://codereview.chromium.org/899313003/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:2216: ScopedCaller<LayerTreeHostImpl>
scoped_release_resources(
On 2015/02/05 20:43:52, enne wrote:
> This seems like overkill.  Neither of the functions this is in has an early
out,
> so maybe just call the two functions you need?
> 
> Also, this is only valid for picture layers, so maybe DestroyTileManager and
> CreateAndSetTileManager could just make these recreate/release calls?

It's ReleaseResources is also implemented in textured layer and video layer, so
I'd prefer to keep the two calls outside of tile manager specific stuff. I
changed this to be explicit calls.

[danakj, 2015-02-05 21:45:22]

LGTM % enne

[enne (OOO), 2015-02-05 21:53:05]

lgtm

[vmpstr, 2015-02-05 22:13:10]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-02-05 22:13:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899313003/20001

[commit-bot: I haz the power, 2015-02-05 23:30:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-05 23:31:01]

Patchset 2 (id:??) landed as
https://crrev.com/9ce5c6661b03f26326f4e5c50924a628eb638afa
Cr-Commit-Position: refs/heads/master@{#314913}