Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 9074012: Convert the remaining Browser::GetSelectedTabContents() calls to GetSelectedWebContents, and upda... (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Jói
CC:
chromium-reviews, tburkard+watch_chromium.org, jam, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, cbentzel+watch_chromium.org, kkania, prasadt, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jstritar+watch_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, jianli, dpranke-watch+content_chromium.org, Dmitry Titov, Aaron Boodman, dominich+watch_chromium.org, robertshield, rdsmith+dwatch_chromium.org, mmenke
Visibility:
Public.

Description

Convert the remaining Browser::GetSelectedTabContents() calls to GetSelectedWebContents, and update all dependent code. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116226

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -501 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_page_capture_api.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_page_capture_api.cc View 1 2 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_apitest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/history/history_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prefetch_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 26 chunks +46 lines, -46 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.mm View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 5 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.h View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.h View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 1 2 9 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 5 chunks +12 lines, -19 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 13 chunks +20 lines, -26 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 6 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.cc View 1 2 6 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 12 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 2 6 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_delegate.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 2 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 2 12 chunks +43 lines, -41 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/mock_download_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mock_download_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mock_download_manager_delegate.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/save_package.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_delegate.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 1 2 7 chunks +16 lines, -15 lines 0 comments Download
M content/public/browser/download_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_manager_delegate.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/notification_types.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/shell/shell_download_manager_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2012-01-03 21:55:28 UTC) #1
Jói
8 years, 11 months ago (2012-01-04 11:04:34 UTC) #2
LGTM

On Tue, Jan 3, 2012 at 9:55 PM, <[email protected]> wrote:

> Reviewers: Jói,
>
> Description:
> Convert the remaining Browser::**GetSelectedTabContents() calls to
> GetSelectedWebContents, and update all dependent code.
>
> BUG=98716
> TBR=joi
>
> Please review this at
http://codereview.chromium.**org/9074012/<http://codereview.chromium.org/9074...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/automation/**automation_provider_observers.**cc
>  M     chrome/browser/custom_**handlers/protocol_handler_**
> registry_browsertest.cc
>  M     chrome/browser/download/**chrome_download_manager_**delegate.h
>  M     chrome/browser/download/**chrome_download_manager_**delegate.cc
>  M     chrome/browser/download/**download_browsertest.cc
>  M     chrome/browser/download/save_**page_browsertest.cc
>  M     chrome/browser/errorpage_**browsertest.cc
>  M     chrome/browser/extensions/**extension_context_menu_**browsertest.cc
>  M     chrome/browser/extensions/**extension_page_capture_api.h
>  M     chrome/browser/extensions/**extension_page_capture_api.cc
>  M     chrome/browser/extensions/**extension_webnavigation_**apitest.cc
>  M     chrome/browser/extensions/**platform_app_browsertest.cc
>  M     chrome/browser/history/**history_tab_helper.h
>  M     chrome/browser/history/**history_tab_helper.cc
>  M     chrome/browser/notifications/**desktop_notification_service.h
>  M     chrome/browser/notifications/**desktop_notification_service.**cc
>  M     chrome/browser/prerender/**prefetch_browsertest.cc
>  M     chrome/browser/prerender/**prerender_browsertest.cc
>  M     chrome/browser/prerender/**prerender_contents.cc
>  M     chrome/browser/referrer_**policy_browsertest.cc
>  M     chrome/browser/sidebar/**sidebar_browsertest.cc
>  M     chrome/browser/tab_contents/**render_view_context_menu.h
>  M     chrome/browser/tab_contents/**render_view_context_menu.cc
>  M     chrome/browser/tab_contents/**render_view_context_menu_**
> browsertest.cc
>  M     chrome/browser/tab_contents/**render_view_context_menu_gtk.h
>  M     chrome/browser/tab_contents/**render_view_context_menu_gtk.**cc
>  M     chrome/browser/tab_contents/**render_view_context_menu_mac.h
>  M    
chrome/browser/tab_contents/re**nder_view_context_menu_mac.mm<http://render_view_context_menu_mac.mm>
>  M     chrome/browser/tab_contents/**render_view_host_delegate_**helper.h
>  M     chrome/browser/tab_contents/**render_view_host_delegate_**helper.cc
>  M     chrome/browser/tab_contents/**web_drag_bookmark_handler_gtk.**h
>  M     chrome/browser/tab_contents/**web_drag_bookmark_handler_gtk.**cc
>  M     chrome/browser/tab_contents/**web_drag_bookmark_handler_mac.**h
>  M    
chrome/browser/tab_contents/we**b_drag_bookmark_handler_mac.mm<http://web_drag_bookmark_handler_mac.mm>
>  M     chrome/browser/tab_contents/**web_drag_source_win.h
>  M     chrome/browser/tab_contents/**web_drag_source_win.cc
>  M     chrome/browser/tab_contents/**web_drop_target_win.h
>  M     chrome/browser/tab_contents/**web_drop_target_win.cc
>  M     chrome/browser/translate/**translate_manager_browsertest.**cc
>  M     chrome/browser/ui/browser.h
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_**browsertest.cc
>  M     chrome/browser/ui/browser_**init.cc
>  M     chrome/browser/ui/browser_**navigator_browsertest.cc
>  M     chrome/browser/ui/cocoa/**location_bar/content_setting_**
> decoration.h
>  M     chrome/browser/ui/cocoa/**location_bar/content_setting_**
> decoration.mm <http://content_setting_decoration.mm>
>  M     chrome/browser/ui/cocoa/**location_bar/location_bar_**view_mac.h
>  M    
chrome/browser/ui/cocoa/**location_bar/location_bar_**view_mac.mm<http://location_bar_view_mac.mm>
>  M     chrome/browser/ui/cocoa/**location_bar/location_icon_**
> decoration.mm <http://location_icon_decoration.mm>
>  M     chrome/browser/ui/cocoa/**location_bar/page_action_**decoration.h
>  M    
chrome/browser/ui/cocoa/**location_bar/page_action_**decoration.mm<http://page_action_decoration.mm>
>  M    
chrome/browser/ui/cocoa/view_**id_util_browsertest.mm<http://view_id_util_browsertest.mm>
>  M     chrome/browser/ui/content_**settings/content_setting_**
> image_model.h
>  M     chrome/browser/ui/content_**settings/content_setting_**
> image_model.cc
>  M     chrome/browser/ui/content_**settings/content_setting_**
> image_model_unittest.cc
>  M     chrome/browser/ui/gtk/browser_**window_gtk.cc
>  M     chrome/browser/ui/gtk/**location_bar_view_gtk.h
>  M     chrome/browser/ui/gtk/**location_bar_view_gtk.cc
>  M     chrome/browser/ui/panels/**panel_browsertest.cc
>  M     chrome/browser/ui/toolbar/**toolbar_model.cc
>  M     chrome/browser/ui/views/**location_bar/content_setting_**
> image_view.h
>  M     chrome/browser/ui/views/**location_bar/content_setting_**
> image_view.cc
>  M     chrome/browser/ui/views/**location_bar/location_bar_**view.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_aura.h
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_aura.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_delegate.h
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_gtk.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_win.h
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> view_win.cc
>  M     chrome/browser/ui/views/tab_**contents/render_view_context_**
> menu_views.h
>  M     chrome/browser/ui/views/tab_**contents/render_view_context_**
> menu_views.cc
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_drag_**win.cc
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_view_**views.h
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_view_**views.cc
>  M     chrome/common/chrome_**notification_types.h
>  M     chrome/test/base/ui_test_**utils.h
>  M     chrome/test/base/ui_test_**utils.cc
>  M     content/browser/download/**download_manager_impl.h
>  M     content/browser/download/**download_manager_impl.cc
>  M     content/browser/download/drag_**download_file.h
>  M     content/browser/download/drag_**download_file.cc
>  M     content/browser/download/mock_**download_manager.h
>  M     content/browser/download/mock_**download_manager.cc
>  M     content/browser/download/mock_**download_manager_delegate.h
>  M     content/browser/download/save_**package.h
>  M     content/browser/download/save_**package.cc
>  M     content/browser/tab_contents/**tab_contents.cc
>  M     content/browser/tab_contents/**web_drag_dest_delegate.h
>  M     content/browser/tab_contents/**web_drag_dest_gtk.h
>  M     content/browser/tab_contents/**web_drag_dest_gtk.cc
>  M     content/browser/tab_contents/**web_drag_source_gtk.h
>  M     content/browser/tab_contents/**web_drag_source_gtk.cc
>  M     content/public/browser/**download_manager.h
>  M     content/public/browser/**download_manager_delegate.h
>  M     content/public/browser/**notification_types.h
>  M     content/public/browser/web_**contents.h
>  M     content/shell/shell_download_**manager_delegate.h
>  M     content/shell/shell_download_**manager_delegate.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698