Separate chrome/common/metrics/metrics_helpers.{h,cc} into files for the constituent classes.

Separate chrome/common/metrics/metrics_helpers.{h,cc} into files for the constituent classes.

BUG=none
TEST=none (code cleanup)
[email protected]


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119345

[Ilya Sherman, 2012-01-19 02:54:06]

(This CL also includes the changes in [ http://codereview.chromium.org/9251033/
].  I am planning to commit that CL first, and rebase this one prior to
committing.)

[Ilya Sherman, 2012-01-25 01:18:49]

Jim, ping.  This is the last cleanup CL prior that the protobufs change in the
Chromium source depends on.

[jar (doing other things), 2012-01-25 20:05:57]

LGTM

Much of this code was refactored historically to better fit in with Chrome
Frame.   Be sure you run try bots to test with Chrome Frame.

I've added ananta to the reviewer list, and he may have a comment (related to
Chrome Frame).

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
File chrome/common/metrics/metrics_service_base.cc (right):

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
chrome/common/metrics/metrics_service_base.cc:7: #include <cstdlib>
What is this needed for?

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
chrome/common/metrics/metrics_service_base.cc:25: const base::Histogram&
histogram,
nit: 4 character indent.

[Ilya Sherman, 2012-01-25 20:42:49]

On 2012/01/25 20:05:57, jar wrote:
> LGTM
> 
> Much of this code was refactored historically to better fit in with Chrome
> Frame.   Be sure you run try bots to test with Chrome Frame.

Yep, I think I've gotten all the Chrome Frame dependencies fixed up as well.  It
looks like the default Windows try jobs run Chrome Frame tests :)

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
File chrome/common/metrics/metrics_service_base.cc (right):

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
chrome/common/metrics/metrics_service_base.cc:7: #include <cstdlib>
On 2012/01/25 20:05:58, jar wrote:
> What is this needed for?

std::abs, on Linux, apparently.  It doesn't help that there's something like 3
separate places where different flavors of std::abs are defined, though ;)

http://codereview.chromium.org/9159004/diff/6001/chrome/common/metrics/metric...
chrome/common/metrics/metrics_service_base.cc:25: const base::Histogram&
histogram,
On 2012/01/25 20:05:58, jar wrote:
> nit: 4 character indent.

Good catch, thanks.

[commit-bot: I haz the power, 2012-01-26 23:17:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9159004/11001

[Ilya Sherman, 2012-01-26 23:17:26]

ananta, I'm going to TBR you on this one.  If you spot any issues after the
fact, please let me know and I'll follow up in a separate CL.

[commit-bot: I haz the power, 2012-01-27 02:35:45]

Change committed as 119345