Wires up disabling visibility animations for aura, and explicitly

chrome/test/base/in_process_browser_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/in_process_browser_test.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/stack_trace.h"
 #include "base/file_path.h"
@@ skipping 28 matching lines @@
 #include "net/test/test_server.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/audio/audio_handler.h"
 #elif defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #endif
 
 #if defined(USE_AURA)
 #include "ui/aura/root_window.h"
+#include "ui/views/widget/widget.h"
 #endif
 
 namespace {
 
 // Passed as value of kTestType.
 const char kBrowserTestType[] = "browser";
 
 }  // namespace
 
 InProcessBrowserTest::InProcessBrowserTest()
@@ skipping 185 matching lines @@
 }
 
 void InProcessBrowserTest::AddBlankTabAndShow(Browser* browser) {
   ui_test_utils::WindowedNotificationObserver observer(
       content::NOTIFICATION_LOAD_STOP,
        content::NotificationService::AllSources());
   browser->AddSelectedTabWithURL(
       GURL(chrome::kAboutBlankURL), content::PAGE_TRANSITION_START_PAGE);
   observer.Wait();
 
+#if defined(USE_AURA)
+  // Disable animations on aura, otherwise any code that gets the bounds may get

[Ben Goodger (Google), 2012/01/24 04:39:13]

// TODO(beng): USE_ASH

+  // the wrong thing.
+  views::Widget* widget = views::Widget::GetWidgetForNativeView(

[Paweł Hajdan Jr., 2012/01/24 19:02:51]

This is perfectly fine. One thing: do we run UI tests with aura? If so, please
share the code so that UI tests disable the animations too (likely candidate is
test_launcher_utils).

+      browser->window()->GetNativeHandle());
+  widget->SetVisibilityChangedAnimationsEnabled(false);

[Ben Goodger (Google), 2012/01/24 04:39:13]

1. looks like you're missing changes to Widget in this CL
2. rather than add to the widget API, how about adding
EnableVisibilityChangedAnimations(aura::Window* window, bool enabled); to
window_animations.h, and then calling it from here with
browser->window()->GetNativeHandle() as |window|.

+#endif
+
   browser->window()->Show();
 }
 
 #if defined(OS_POSIX)
 // On SIGTERM (sent by the runner on timeouts), dump a stack trace (to make
 // debugging easier) and also exit with a known error code (so that the test
 // framework considers this a failure -- http://crbug.com/57578).
 static void DumpStackTraceSignalHandler(int signal) {
   base::debug::StackTrace().PrintBacktrace();
   _exit(128 + signal);
@@ skipping 60 matching lines @@
   if (BrowserList::size() == 0)
     return;
 
   // Invoke CloseAllBrowsersAndMayExit on a running message loop.
   // CloseAllBrowsersAndMayExit exits the message loop after everything has been
   // shut down properly.
   MessageLoopForUI::current()->PostTask(FROM_HERE,
                                         base::Bind(&BrowserList::AttemptExit));
   ui_test_utils::RunMessageLoop();
 }