WebWidgetClient::screenInfo() no longer does a synchronous IPC.

WebWidgetClient::screenInfo() no longer does a synchronous IPC.
Instead it grabs the necessary info from a cached WebScreenInfo factory.

BUG=111401
TEST=Manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124453

[lain Merrick, 2012-01-31 12:42:09]

https://chromiumcodereview.appspot.com/9302022/diff/1/content/browser/rendere...
File content/browser/renderer_host/render_view_host.cc (right):

https://chromiumcodereview.appspot.com/9302022/diff/1/content/browser/rendere...
content/browser/renderer_host/render_view_host.cc:207:
params.WebKit::WebScreenInfoFactory::screenInfo(
params.WebKit looks wrong.

And this may still call screenInfo() with NULL, right? Maybe just add a NULL
check here?

https://chromiumcodereview.appspot.com/9302022/diff/1/content/renderer/render...
File content/renderer/render_widget_fullscreen.cc (right):

https://chromiumcodereview.appspot.com/9302022/diff/1/content/renderer/render...
content/renderer/render_widget_fullscreen.cc:49: :
RenderWidget(WebKit::WebPopupTypeNone, WebKit::WebScreenInfo()) {
Seems OK to leave this as a TODO for now, but does it definitely work this way?

Will it be implemented by a future ViewMsg_ScreenInfoUpdated message?

[Fady Samuel, 2012-01-31 19:54:11]

https://chromiumcodereview.appspot.com/9302022/diff/1/content/browser/rendere...
File content/browser/renderer_host/render_view_host.cc (right):

https://chromiumcodereview.appspot.com/9302022/diff/1/content/browser/rendere...
content/browser/renderer_host/render_view_host.cc:207:
params.WebKit::WebScreenInfoFactory::screenInfo(
On 2012/01/31 12:42:09, Iain Merrick wrote:
> params.WebKit looks wrong.
> 
> And this may still call screenInfo() with NULL, right? Maybe just add a NULL
> check here?

It probably is. I'm trying to update and test on Windows now (I mostly working
on Linux so there's a bit of latency to get a fresh sync'ed version of chromium
tested with this patch on Windows).

https://chromiumcodereview.appspot.com/9302022/diff/1/content/renderer/render...
File content/renderer/render_widget_fullscreen.cc (right):

https://chromiumcodereview.appspot.com/9302022/diff/1/content/renderer/render...
content/renderer/render_widget_fullscreen.cc:49: :
RenderWidget(WebKit::WebPopupTypeNone, WebKit::WebScreenInfo()) {
Yea, it needs to...I will do this in a subsequent patch.

[Fady Samuel, 2012-02-28 22:39:06]

Updated to compile on Windows and merge with TOT. Sorry for the delay, was out
of the office, and didn't have access to a Windows machine for a little while
and then got distracted by another task.

[jam, 2012-02-29 23:41:16]

http://codereview.chromium.org/9302022/diff/9001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/9302022/diff/9001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:213: if (view())
brace brackets here and below per style guide

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
File content/renderer/render_widget.cc (left):

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
content/renderer/render_widget.cc:1594: Send(new
ViewHostMsg_GetScreenInfo(routing_id_, host_window_, &results));
this IPC, and the code that dispatches it, can now be removed

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
content/renderer/render_widget.h:161: explicit RenderWidget(WebKit::WebPopupType
popup_type,
nit: no need for explicit

[Fady Samuel, 2012-03-01 00:52:24]

http://codereview.chromium.org/9302022/diff/9001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/9302022/diff/9001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:213: if (view())
On 2012/02/29 23:41:17, John Abd-El-Malek wrote:
> brace brackets here and below per style guide

Done.

http://codereview.chromium.org/9302022/diff/9001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:213: if (view())
On 2012/02/29 23:41:17, John Abd-El-Malek wrote:
> brace brackets here and below per style guide

Done.

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
File content/renderer/render_widget.cc (left):

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
content/renderer/render_widget.cc:1594: Send(new
ViewHostMsg_GetScreenInfo(routing_id_, host_window_, &results));
On 2012/02/29 23:41:17, John Abd-El-Malek wrote:
> this IPC, and the code that dispatches it, can now be removed

Done.

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/9302022/diff/9001/content/renderer/render_widg...
content/renderer/render_widget.h:161: explicit RenderWidget(WebKit::WebPopupType
popup_type,
On 2012/02/29 23:41:17, John Abd-El-Malek wrote:
> nit: no need for explicit

True, thanks.

[jam, 2012-03-01 01:00:16]

http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host.cc (left):

http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host.cc:1305:
view_->GetScreenInfo(results);
both this method and the one below are now not called anymore, so you should
remove that code as well..

[Fady Samuel, 2012-03-01 01:02:38]

http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host.cc (left):

http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host.cc:1305:
view_->GetScreenInfo(results);
On 2012/03/01 01:00:17, John Abd-El-Malek wrote:
> both this method and the one below are now not called anymore, so you should
> remove that code as well..

They are, they've just been moved into RenderViewHost.

[jam, 2012-03-01 01:06:34]

On 2012/03/01 01:02:38, Fady Samuel wrote:
>
http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
> File content/browser/renderer_host/render_widget_host.cc (left):
> 
>
http://codereview.chromium.org/9302022/diff/13002/content/browser/renderer_ho...
> content/browser/renderer_host/render_widget_host.cc:1305:
> view_->GetScreenInfo(results);
> On 2012/03/01 01:00:17, John Abd-El-Malek wrote:
> > both this method and the one below are now not called anymore, so you should
> > remove that code as well..
> 
> They are, they've just been moved into RenderViewHost.

oops, sorry I was looking at cs and forgot about the movement

lgtm

[commit-bot: I haz the power, 2012-03-01 01:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9302022/13002

[commit-bot: I haz the power, 2012-03-01 02:18:31]

Try job failure for 9302022-13002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Iain Merrick, 2012-03-01 11:58:12]

lgtm

[commit-bot: I haz the power, 2012-03-01 16:37:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9302022/24001

[commit-bot: I haz the power, 2012-03-01 19:46:42]

Change committed as 124453