Issue 9372020: Reland 121057 - Use PluginInstaller to update outdated plug-ins.

Issue 9372020: Reland 121057 - Use PluginInstaller to update outdated plug-ins. (Closed)

Created:
8 years, 10 months ago by Bernhard Bauer

Modified:
8 years, 10 months ago

Reviewers:
battre

CC:
chromium-reviews, jam, arv (Not doing code reviews), darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland 121057 - Use PluginInstaller to update outdated plug-ins. Original review at http://codereview.chromium.org/9107038/. [email protected] BUG=92796 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121239

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : '' #

Patch Set 4 : nit #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+822 lines, -551 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/plugin_finder.h	View		3 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/plugin_finder.cc	View		2 chunks	+89 lines, -49 lines	0 comments	Download
A	chrome/browser/plugin_infobar_delegates.h	View	1	1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/browser/plugin_infobar_delegates.cc	View	1	1 chunk	+392 lines, -0 lines	0 comments	Download
M	chrome/browser/plugin_installer.h	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/plugin_installer.cc	View		3 chunks	+10 lines, -4 lines	0 comments	Download
D	chrome/browser/plugin_installer_infobar_delegate.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download
D	chrome/browser/plugin_installer_infobar_delegate.cc	View		1 chunk	+0 lines, -128 lines	0 comments	Download
M	chrome/browser/plugin_observer.h	View	1 2 3	2 chunks	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/plugin_observer.cc	View	1	9 chunks	+40 lines, -282 lines	0 comments	Download
A	chrome/browser/resources/plugins_linux.json	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/renderer/plugins/plugin_placeholder.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

Please review. For comparison, the old version is in patch set 1.

8 years, 10 months ago (2012-02-09 12:05:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/9372020/3005

8 years, 10 months ago (2012-02-09 13:59:39 UTC) #3

Change committed as 121239

Expand Messages | Collapse Messages