Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Issue 94013004: Add base:: to string16s in chrome/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, chrisgao (Use stgao instead), frankf, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, robertshield, tfarina, chromium-apps-reviews_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1230 lines, -1172 lines) Patch
M chrome/android/testshell/testshell_tab.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/testshell/testshell_tab.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/app_mode_loader_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_breakpad_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/client_util.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/client_util.cc View 7 chunks +21 lines, -20 lines 0 comments Download
M chrome/app/metro_driver_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment_test.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/installer/gcapi/gcapi_reactivation_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/launcher_support/chrome_launcher_support.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/archive_patch_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 30 chunks +45 lines, -42 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 12 chunks +20 lines, -21 lines 0 comments Download
M chrome/installer/setup/uninstall.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 20 chunks +38 lines, -38 lines 0 comments Download
M chrome/installer/util/app_command.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/app_command.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/auto_launch_util.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/auto_launch_util.cc View 9 chunks +19 lines, -18 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 3 chunks +27 lines, -25 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 6 chunks +25 lines, -24 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.h View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.cc View 4 chunks +27 lines, -27 lines 0 comments Download
M chrome/installer/util/chrome_app_host_operations.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/chrome_app_host_operations.cc View 8 chunks +15 lines, -12 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 4 chunks +24 lines, -23 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.cc View 8 chunks +16 lines, -12 lines 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.h View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.cc View 3 chunks +32 lines, -32 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_binaries_distribution.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/installer/util/google_chrome_binaries_distribution.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 4 chunks +22 lines, -22 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 11 chunks +40 lines, -39 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 4 chunks +37 lines, -36 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/installer/util/google_update_experiment_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_experiment_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 9 chunks +15 lines, -13 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/install_util.h View 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/installer/util/install_util.cc View 15 chunks +28 lines, -27 lines 0 comments Download
M chrome/installer/util/installation_validator.h View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/installer/util/installation_validator.cc View 14 chunks +20 lines, -19 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_util_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/l10n_string_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/product_operations.h View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/shell_util.h View 17 chunks +42 lines, -37 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 68 chunks +186 lines, -171 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 19 chunks +35 lines, -31 lines 0 comments Download
M chrome/installer/util/uninstall_metrics.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/uninstall_metrics.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/uninstall_metrics_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/user_experiment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/user_experiment.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M chrome/installer/util/wmi.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/wmi.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_xps_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/capabilities.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_x.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/perf/generate_profile.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/unpacker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/extensions/unpacker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/utility/importer/firefox_importer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 12 chunks +22 lines, -23 lines 0 comments Download
M chrome/utility/importer/nss_decryptor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/nss_decryptor_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/nss_decryptor_null.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/utility/importer/nss_decryptor_system_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/nss_decryptor_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/safari_importer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/safari_importer.mm View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/utility/importer/safari_importer_unittest.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/utility/media_galleries/itunes_library_parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dan Beam
7 years ago (2013-12-20 05:17:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/94013004/20001
7 years ago (2013-12-20 07:19:24 UTC) #2
Dan Beam
7 years ago (2013-12-20 09:03:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r242048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698