Change the "close Chrome with downloads in progress" dialog to resemble kenmoore's mock

Change the "close Chrome with downloads in progress" dialog to resemble kenmoore's mock
from issue 122037. Also use different text when exiting incognito mode (issue 88421).


BUG=122037, 88421
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133977

[benrg, 2012-04-17 01:32:44]

Oshima, can you review this or recommend somebody?

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2740: +        Downloads in progress
The old messages mentioned how many downloads were in progress. Should I have
kept that information?

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2758: +        No
I use the same "Yes" string for single and multiple downloads, and the same "No"
string for all four dialog variants (single/multiple, Chrome/incognito). Are
there any languages where that will be a problem?

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.cc
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
I'm still pretty clueless about Chrome memory management. Please check that
there are no leaks or double-frees in this code.

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.h
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.h:19: class
DownloadInProgressDialogView : public views::DialogDelegate {
Should this be in the views namespace?

Should I rename this class to "DownloadInProgressDialog" since it's no longer a
View?

[benrg, 2012-04-17 18:06:59]

James, can you review this or recommend somebody? See my inline questions.

[James Cook, 2012-04-17 19:03:21]

LGTM with one optional suggestion for a switch statement.

You'll need a review from OWNERS of chrome/browser/ui, which is sky, ben, or
pkasting.

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2740: +        Downloads in progress
On 2012/04/17 01:32:44, benrg wrote:
> The old messages mentioned how many downloads were in progress. Should I have
> kept that information?

I think it's fine to leave it out.

http://codereview.chromium.org/9969193/diff/1006/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2758: +        No
On 2012/04/17 01:32:44, benrg wrote:
> I use the same "Yes" string for single and multiple downloads, and the same
"No"
> string for all four dialog variants (single/multiple, Chrome/incognito). Are
> there any languages where that will be a problem?

I think that's also OK.  I'm not aware of languages where the count of something
would modify a yes/no.

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.cc
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2012/04/17 01:32:44, benrg wrote:
> I'm still pretty clueless about Chrome memory management. Please check that
> there are no leaks or double-frees in this code.

I think this is OK.  The semantics of memory cleanup when windows are being
closed is tricky, but it looks like other people are using DeleteDelegate() the
way you have and I think it's correct.

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.cc:43: if
(type == Browser::DOWNLOAD_CLOSE_BROWSER_SHUTDOWN) {
Maybe a switch statement on the type with a NOTREACHED() for the
DOWNLOAD_CLOSE_OK case might be a little clearer?

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.h
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.h:19: class
DownloadInProgressDialogView : public views::DialogDelegate {
On 2012/04/17 01:32:44, benrg wrote:
> Should this be in the views namespace?
> 
> Should I rename this class to "DownloadInProgressDialog" since it's no longer
a
> View?

I don't think it should be in the views namespace.  I believe the views
namespace is used for the implementation of views (hence views::Label,
views::Button, etc.) but not for users of views.  We do a similar thing with
test utilities - test utils are often in a test:: namespace, but that doesn't
mean every test is in that namespace.

Since it is no longer a view, I think renaming the file and class is a good
idea.

[benrg, 2012-04-17 20:39:14]

Ben, requesting owner approval. Also see the question below about renaming.

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.cc
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.cc:43: if
(type == Browser::DOWNLOAD_CLOSE_BROWSER_SHUTDOWN) {
On 2012/04/17 19:03:21, James Cook (Chromium) wrote:
> Maybe a switch statement on the type with a NOTREACHED() for the
> DOWNLOAD_CLOSE_OK case might be a little clearer?

Done.

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_in_progress_dialog_view.h
(right):

http://codereview.chromium.org/9969193/diff/1006/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_in_progress_dialog_view.h:19: class
DownloadInProgressDialogView : public views::DialogDelegate {
On 2012/04/17 19:03:21, James Cook (Chromium) wrote:
> Since it is no longer a view, I think renaming the file
> and class is a good idea.

On second thought the View suffix may just mean "the views implementation of
this dialog". DownloadShelfContextMenuView is a DownloadShelfContextMenu but not
a View. Ben G, what should I do?

[benrg, 2012-04-24 20:20:04]

James, PTAL. GTK and Mac implementations added. I haven't tested the Mac
implementation since I don't have a Mac build environment. It builds on the
trybot and the changes are small enough (just renaming some identifiers) that I
think it's safe.

[James Cook, 2012-04-24 20:51:54]

LGTM!  I think your reasoning on Mac is sound - if it builds OK on the bots, I
think you're fine.

[benrg, 2012-04-24 21:28:03]

Ben, requesting owner approval.

[Ben Goodger (Google), 2012-04-25 15:29:57]

lgtm

[commit-bot: I haz the power, 2012-04-25 19:21:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9969193/14005

[commit-bot: I haz the power, 2012-04-25 21:03:50]

Change committed as 133977