Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2730893002: Revert of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (Closed)

Created:
3 years, 9 months ago by danilchap
Modified:
3 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (patchset #2 id:20001 of https://codereview.webrtc.org/2728103002/ ) Reason for revert: Fails on tsan http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/10235 Original issue's description: > Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo > Add extra checks to it to simplify diagnostic should it fail again. > > BUG=webrtc:7292 > > Review-Url: https://codereview.webrtc.org/2728103002 > Cr-Commit-Position: refs/heads/master@{#16999} > Committed: https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7292 Review-Url: https://codereview.webrtc.org/2730893002 Cr-Commit-Position: refs/heads/master@{#17000} Committed: https://chromium.googlesource.com/external/webrtc/+/9a59473f2c403827a3560944c7ffe76d37ab77b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M webrtc/video/end_to_end_tests.cc View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danilchap
Created Revert of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo
3 years, 9 months ago (2017-03-03 13:04:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2730893002/1
3 years, 9 months ago (2017-03-03 13:04:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/9a59473f2c403827a3560944c7ffe76d37ab77b9
3 years, 9 months ago (2017-03-03 13:04:53 UTC) #6
danilchap
3 years, 9 months ago (2017-03-03 13:34:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2730673004/ by [email protected].

The reason for reverting is: Fixing race and relanding .

Powered by Google App Engine
This is Rietveld 408576698