Skip to content

Add missing IPC file for PSA Firmware Update #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 22, 2021

This PR tries to add missing IPC file for PSA Firmware Update. It address #120.

Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LDong-Arm LDong-Arm self-requested a review July 22, 2021 09:43
On a target that doesn't support Firmware Update, compilation still works, and any attempt to call the Firmware Update API returns a runtime error which is good enough.

Because it's not supported yet on Musca S1, move it to ARM_MUSCA_B1.

Fixes ARMmbed#120
@ccli8 ccli8 force-pushed the nuvoton_tfm_missing_update branch from 668eac9 to 61eda3d Compare July 23, 2021 01:25
@ccli8
Copy link
Contributor Author

ccli8 commented Jul 23, 2021

Because it's not supported on Musca S1, could you please move it to ARM_MUSCA_B1 above?

@LDong-Arm Moved to under ARM_MUSCA_B1

Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater Patater merged commit 0fb365e into ARMmbed:master Jul 29, 2021
@ccli8 ccli8 deleted the nuvoton_tfm_missing_update branch July 30, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants