K64F: Fix pin names and migrate to Arduino Uno form factor #14837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Standard Pin Names porting guide, pinvalidate.py is run without prefixing the "python" command. But to make it possible, a shebang needs to exist.
Fix pin names of K64F with the following from the latest guidelines: * LEDs and buttons are defined as macros, digital and analog pins as enums. * No duplicated pin names with the same value. * The Arduino form factor is deprecated in favour of Arduino Uno. Note: The pins `SPI_xxx` are for SD card only, but the names are kept for backward compatibility (i.e. no breaking change until the next Mbed OS major version). The general purpose Arduino Uno SPI pins (`ARDUINO_UNO_SPI_xxx`) are different and also available.
|
@LDong-Arm, thank you for your changes. |
0xc0170
reviewed
Jun 29, 2021
| // (ARDUINO_UNO_SPI_xxx) for general purpose uses. | ||
| // By default, Mbed OS maps those alias to Arduino Uno pins, but | ||
| // for backward compatibility we map them to the SD card SPI. | ||
| #define SPI_MOSI PTE3 |
There was a problem hiding this comment.
This is also part of the migration, couldn't it stay in PinName enum and just add a comment or?
There was a problem hiding this comment.
The SPI pins need to be #defined:
mbed-os/hal/include/hal/PinNameAliases.h
Lines 170 to 173 in 81aaef4
If they were enums, the macro checks would not work.
MarceloSalazar
approved these changes
Jun 29, 2021
0xc0170
approved these changes
Jun 29, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix pin names of K64F with the following from the latest guidelines:
Note: The pins
SPI_xxxare for SD card only, but the names are kept for backward compatibility (i.e. no breaking change until the next Mbed OS major version). The general purpose Arduino Uno SPI pins (ARDUINO_UNO_SPI_xxx) are different and also available.Impact of changes
Migration actions required
This change is non-breaking because PinNameAliases.h maps generic pin names (e.g.
A0) <--> Arduino Uno pin names (e.g.ARDUINO_UNO_A0) unless otherwise defined. Nonetheless, projects can take advantage of Arduino Uno pin names when available.Documentation
None.
Pull request type
Test results
pinvalidate.pytests and Greentea tests (*-pin_names*-) pass.*-COMPONENT_SD-*) pass with an SD card inserted, to validate SD card SPI pin maps.Reviewers
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/team-nxp