Remove the UNITTEST macro from production code
#14884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Production code should not contain any test-specific checks. Rather than checking `UNITTEST`, unit tests can directly set `MBED_CONF_RTOS_PRESENT=1` to make RTOS available for testing. Note: The cellular ATHandler test also has `MBED_CONF_RTOS_PRESENT=1` added because `ATHandler.cpp` contains a check of this variable.
The stub version of mbed_assert.h is never used outside unit tests, so the check on `UNITTEST` is redundant.
The stub version of <mstd_type_traits> is mostly identical to the production file of the same name, except the former lags behind and doesn't contain the recent "is_constant_evaluated" feature. It's safe to update the stub file, because "is_constant_evaluated" only checks generic GCC and Clang versions that also apply to compilers on PCs. This enables MbedCRC.h to include <mstd_type_traits> without distinguishing between Mbed applications and unit tests.
Production code should not contain any test-specific checks. Rather than checking `UNITTEST`, MbedCRC.h can simply include in all cases <mstd_type_traits> whose unit test stub exists. Also remove the `UNITTEST` macro from CMake definitions of kvstore unit tests which depend on MbedCRC.h.
|
@LDong-Arm, thank you for your changes. |
rwalton-arm
approved these changes
Jul 7, 2021
0xc0170
approved these changes
Jul 7, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #14883
Following discussion in #14870 (comment), we agree that production code should not contain any test-specific checks - stubs/fakes/mocks/... should be sufficient.
This PR removes the
UNITTESTmacro from the entire Mbed OS code base. For details, see individual commit messages.Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@rajkan01 @rwalton-arm @ARMmbed/mbed-os-core