STM32WB/STM32WL: I2C issue #15133
Merged
STM32WB/STM32WL: I2C issue #15133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
0xc0170
previously requested changes
Oct 11, 2021
a "else" was missing for
uint32_t i2c_get_pclk(I2CName i2c)
if (i2c == I2C_1) {
else if (i2c == I2C_2) {
else if (i2c == I2C_3) {
else {
error("I2C: unknown instance");
Done |
0xc0170
approved these changes
Oct 12, 2021
|
CI restared |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We got an assert if the application was using I2C1 with a STM32WL
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers