Skip to content

Commit 573dd6b

Browse files
authored
[rqd] Fix issue on rqd when killing a frame that no longer exists (#1533)
When killing a frame on a rqd node that has restarted and lost track of its running frames, the request should return a status to be handled accordingly and trigger the lostProc logic. The current behavior leaves the frame stuck at RUNNING until the job itself is killed or eaten.
1 parent 6e2ed87 commit 573dd6b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

rqd/rqd/rqdservicers.py

+4
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ def KillRunningFrame(self, request, context):
6868
if frame:
6969
frame.kill(message=request.message)
7070
else:
71+
context.set_details(
72+
"The requested frame to kill was not found. frameId: {}".format(
73+
request.frame_id))
74+
context.set_code(grpc.StatusCode.NOT_FOUND)
7175
log.warning("Wasn't able to find frame(%s) to kill", request.frame_id)
7276
return rqd.compiled_proto.rqd_pb2.RqdStaticKillRunningFrameResponse()
7377

0 commit comments

Comments
 (0)