System logging pipeline #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Aug 18, 2019
There was a problem hiding this comment.
Thanks. Mostly looks good. lets discuss with @mhoeger if call back to log system logs within the context for invocation makes sense or not.
src/Context.ts
Outdated
| if (done) { | ||
| let badAsyncMsg = "Warning: Unexpected call to 'log' on the context object after function execution has completed. Please check for asynchronous calls that are not awaited or calls to 'done' made before function execution completes. "; | ||
| badAsyncMsg += `Function name: ${executionContext.functionName}. Invocation Id: ${executionContext.invocationId}. `; | ||
| badAsyncMsg += `Learn more: https://go.microsoft.com/fwlink/?linkid=2097909 `; | ||
| log(LogLevel.Warning, badAsyncMsg); | ||
| systemWarn(badAsyncMsg); | ||
| systemLog(SystemLogLevel.Warning, executionContext.functionName, executionContext.invocationId, badAsyncMsg); |
There was a problem hiding this comment.
With in the execution context, we should not be logging system logs
3b6fbab to
1cd39ed
Compare
mhoeger
reviewed
Sep 18, 2019
mhoeger
reviewed
Sep 18, 2019
mhoeger
reviewed
Sep 18, 2019
mhoeger
suggested changes
Sep 18, 2019
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhoeger
approved these changes
Sep 20, 2019
272f94f to
f250295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work for Azure/azure-functions-host#3117