Change the order the different versions of API are registered

[caesarxuchao]

Register the API versions to the DefaultRESTMapper in the order of preferred versions first.

This makes kubectl sends requests to URLs in the format defined by the latest version of API, thus fixing #7512, #7260, and #7491

[j3ffml]

cc @bgrant0607

[smarterclayton]

LGTM

[nikhiljindal]

You can delete this TODO

[caesarxuchao]

Hi @smarterclayton, the shippable fails because the test-cmd.sh fails. These lines cause the problem:

if [[ "${version}" != "v1beta3" ]]; then
    kube::log::status "Testing kubectl(${version}:minions)"
    kube::test::get_object_assert minions "{{range.items}}{{$id_field}}:{{end}}" '127.0.0.1:'
...

It's called when ${version} = "". I think the nil version means the default version, which is now v1beta3. So I guess we should modify the script to skip the minions test when version is nil. Am I right? Thanks.

[nikhiljindal]

Yes. You can change that if condition to

  if [ "${version}" = "v1beta1" ] || [ "${version}" = "v1beta2" ]; then

[caesarxuchao]

Hi @smarterclayton , just out of curious, what does this line do in test-cmd.sh?

[ "$(kubectl get minions -t $'{{ .apiVersion }}' "${kube_flags[@]}")" == "v1beta3" ]

Why is there a $ sign before the template "$'{{ .apiVersion }}'"? And where is the test result used? I searched for "$?" but there is none. I know very little about bash..

[smarterclayton]

Correct, now that v1beta3 is the default the empty API version will not have minions as the default name.

On May 1, 2015, at 5:53 PM, Chao Xu [email protected] wrote:

Hi @smarterclayton, the shippable fails because the test-cmd.sh fails. These lines cause the problem:

if [[ "${version}" != "v1beta3" ]]; then
kube::log::status "Testing kubectl(${version}:minions)"
kube::test::get_object_assert minions "{{range.items}}{{$id_field}}:{{end}}" '127.0.0.1:'
...
It's called when ${version} = "". I think the nil version means the default version, which is now v1beta3. So I guess we should modify the script to skip the minions test when version is nil. Am I right? Thanks.

—
Reply to this email directly or view it on GitHub.

[smarterclayton]

That's a great question I believe that might be the result of a copy and paste bug - I don't think that $ should be there.

On May 1, 2015, at 5:59 PM, Chao Xu [email protected] wrote:

Hi @smarterclayton , just out of curious, I have an irrelevant question about the test-cmd.sh. What does this line do?

[ "$(kubectl get minions -t $'{{ .apiVersion }}' "${kube_flags[@]}")" == "v1beta3" ]
Why is there a $ sign before the template "$'{{ .apiVersion }}'"? And where is the test result used? I searched for "$?" but there is none. I know very little about bash..

—
Reply to this email directly or view it on GitHub.

[caesarxuchao]

Hi @smarterclayton, the PR passes the shippable, could you merge it? Thanks.

[smarterclayton]

Rerunning travis

[smarterclayton]

LGTM