-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Create docker image for kubelet #7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A couple things I found about the wheezy backport used by the hypercube image:
So, I used centos for now; I'm completely open to suggestions about a better image to use. |
@@ -0,0 +1,2 @@ | |||
kubelet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we tend not to add .gitignore
files :P
LGTM, nothing really a blocker. |
How are we going to handle development version kubelet image? |
@dchen1107 For that, there's a 'local' target in the makefile. There are a ton of ways we could automate it a bit better -- any preference? |
Ok, I'm going to remove the gitignore file. Let's make a follow-up issue to make the image uniform with the other 'official' images. To me it would be ideal to just be able to build static binaries and dump them into a scratch image, but there are a couple packages in the kubelet that need native code. |
Aight, should be ready to go in, assuming everyone is cool w/ redirect to host logfile as a follow-up. |
LGTM, will merge tomorrow during merge hours. |
Create docker image for kubelet
@vmarmol Not sure who else to tag on this one.