Skip to content

Create docker image for kubelet #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2015

Conversation

pmorie
Copy link
Contributor

@pmorie pmorie commented May 5, 2015

@vmarmol Not sure who else to tag on this one.

@vmarmol vmarmol self-assigned this May 5, 2015
@pmorie
Copy link
Contributor Author

pmorie commented May 5, 2015

A couple things I found about the wheezy backport used by the hypercube image:

  1. Not the right version of libc required for kubelet
  2. No nsenter binary even though util-linux is installed

So, I used centos for now; I'm completely open to suggestions about a better image to use.

@@ -0,0 +1,2 @@
kubelet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tend not to add .gitignore files :P

@vmarmol
Copy link
Contributor

vmarmol commented May 5, 2015

LGTM, nothing really a blocker.

@dchen1107
Copy link
Member

How are we going to handle development version kubelet image?

@pmorie
Copy link
Contributor Author

pmorie commented May 5, 2015

@dchen1107 For that, there's a 'local' target in the makefile. There are a ton of ways we could automate it a bit better -- any preference?

@pmorie
Copy link
Contributor Author

pmorie commented May 6, 2015

Ok, I'm going to remove the gitignore file. Let's make a follow-up issue to make the image uniform with the other 'official' images. To me it would be ideal to just be able to build static binaries and dump them into a scratch image, but there are a couple packages in the kubelet that need native code.

@pmorie
Copy link
Contributor Author

pmorie commented May 6, 2015

Aight, should be ready to go in, assuming everyone is cool w/ redirect to host logfile as a follow-up.

@vmarmol
Copy link
Contributor

vmarmol commented May 6, 2015

LGTM, will merge tomorrow during merge hours.

@vmarmol vmarmol added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2015
jszczepkowski added a commit that referenced this pull request May 6, 2015
Create docker image for kubelet
@jszczepkowski jszczepkowski merged commit ce590ff into kubernetes:master May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants