Skip to content

fix: prepared statement could return error 'This ResultSet is closed' #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

olavloite
Copy link
Collaborator

Executing a query using a server side prepared statement in a read/write transaction
would return the error "This ResultSet is closed". This happened because the result
set that was used to describe the statement would be closed before the actual result
was sent.

Fixes #278

Executing a query using a server side prepared statement in a read/write transaction
would return the error "This ResultSet is closed". This happened because the result
set that was used to describe the statement would be closed before the actual result
was sent.

Fixes #278
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #279 (01f1563) into postgresql-dialect (fe56a53) will increase coverage by 0.00%.
The diff coverage is 96.29%.

@@                  Coverage Diff                  @@
##             postgresql-dialect     #279   +/-   ##
=====================================================
  Coverage                 82.29%   82.29%           
- Complexity                 1277     1278    +1     
=====================================================
  Files                       102      102           
  Lines                      4410     4411    +1     
  Branches                    548      546    -2     
=====================================================
+ Hits                       3629     3630    +1     
  Misses                      598      598           
  Partials                    183      183           
Flag Coverage Δ
all_tests 82.29% <96.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pter/statements/IntermediatePreparedStatement.java 84.26% <95.45%> (-0.27%) ⬇️
.../pgadapter/metadata/DescribeStatementMetadata.java 100.00% <100.00%> (ø)
...panner/pgadapter/wireprotocol/DescribeMessage.java 84.37% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe56a53...01f1563. Read the comment docs.

@olavloite olavloite merged commit 3383738 into postgresql-dialect Jul 13, 2022
@olavloite olavloite deleted the close-describe-metadata branch July 13, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepared statement in transaction returns FAILED_PRECONDITION: This ResultSet is closed
1 participant