sync matrices on parent process before fork #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
==========================================
+ Coverage 91.91% 91.93% +0.02%
==========================================
Files 239 239
Lines 20292 20293 +1
==========================================
+ Hits 18651 18657 +6
+ Misses 1641 1636 -5
Continue to review full report at Codecov.
|
AviAvni
previously approved these changes
Sep 13, 2021
8f7c4aa to
f5a582a
Compare
0ca8f8a to
71268e2
Compare
AviAvni
pushed a commit
that referenced
this pull request
Sep 14, 2021
* sync matrices on parent process before fork * formatting
AviAvni
pushed a commit
that referenced
this pull request
Sep 14, 2021
* sync matrices on parent process before fork * formatting
swilly22
added a commit
that referenced
this pull request
Sep 14, 2021
* Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * Aliases in WITH...ORDER BY must be valid references (#1897) * Ensure aliases in the ORDER BY segment of a WITH clause are valid references * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * increase code coverage (#1919) * clean unused files * delete v5 decoder * test decoders * fix build * delete unused functions * add deleted nodes and edges to rdb * fix unused function * address review * Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * Storing test artifacts for CI runs (#1906) * Storing test artifacts * PR comments Co-authored-by: Roi Lipman <[email protected]> * Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * sync matrices on parent process before fork (#1931) * sync matrices on parent process before fork * formatting * Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: Jeffrey Lovitz <[email protected]> Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: Chayim <[email protected]>
AviAvni
pushed a commit
that referenced
this pull request
Sep 14, 2021
* sync matrices on parent process before fork * formatting
swilly22
added a commit
that referenced
this pull request
Sep 15, 2021
* Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * Aliases in WITH...ORDER BY must be valid references (#1897) * Ensure aliases in the ORDER BY segment of a WITH clause are valid references * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * increase code coverage (#1919) * clean unused files * delete v5 decoder * test decoders * fix build * delete unused functions * add deleted nodes and edges to rdb * fix unused function * address review * Storing test artifacts for CI runs (#1906) * Storing test artifacts * PR comments Co-authored-by: Roi Lipman <[email protected]> * sync matrices on parent process before fork (#1931) * sync matrices on parent process before fork * formatting * fix tests * fix bgsave * Error when setting a property to an array containing an invalid type (#1898) * Emit error when setting a property to an array containing an invalid type * Address PR comments * Address PR comments * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * Aliases in WITH...ORDER BY must be valid references (#1897) * Ensure aliases in the ORDER BY segment of a WITH clause are valid references * Address PR comments Co-authored-by: Roi Lipman <[email protected]> * increase code coverage (#1919) * clean unused files * delete v5 decoder * test decoders * fix build * delete unused functions * add deleted nodes and edges to rdb * fix unused function * address review * Storing test artifacts for CI runs (#1906) * Storing test artifacts * PR comments Co-authored-by: Roi Lipman <[email protected]> * sync matrices on parent process before fork (#1931) * sync matrices on parent process before fork * formatting * fix tests * fix bgsave * fix timeout test Co-authored-by: Jeffrey Lovitz <[email protected]> Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: Chayim <[email protected]>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* sync matrices on parent process before fork * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#599
in case a readers is syncing a matrix while
BGSAVEis called child process might inherit a lock matrixthis PR moves matrix sync to parent just before forking