Skip to content

All ops NULL-set variables in their free routines #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Conversation

jeffreylovitz
Copy link
Contributor

Update OpFree routines to work safely with the PropagateFree logic.

This fixes (at minimum) a possible crash in variable-length traversals. The crash occurred in the query:

MATCH (a)-[*]->(b)<-[*]-(c) MATCH (b)-[*]->(d) SET a.test = false, b.test = true, c.test = b.name

Copy link
Contributor

@swilly22 swilly22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there was a transition to this type of safe free function for all operations, I guess we've missed a few

@swilly22 swilly22 merged commit 6ac3420 into master Aug 24, 2019
@jeffreylovitz jeffreylovitz deleted the update-op-frees branch August 25, 2019 13:13
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants