Skip to content

Docker: Update dependencies version #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged

Docker: Update dependencies version #2885

merged 1 commit into from
Jul 6, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jul 6, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Update OpenTelemetry, gRPC, Netty, and other dependencies to latest versions

  • Increase GitHub Actions timeout from 160 to 180 minutes

  • Fix Chrome and Edge repository configuration issues

  • Comment out Ubuntu sources list configuration


Changes diagram

flowchart LR
  A["Dependencies"] --> B["OpenTelemetry 1.51.0"]
  A --> C["gRPC 1.73.0"]
  A --> D["Netty 4.1.122.Final"]
  E["Repository Config"] --> F["Chrome sources fix"]
  E --> G["Edge sources fix"]
  H["CI/CD"] --> I["Timeout increase"]
Loading

Changes walkthrough 📝

Relevant files
Dependencies
Dockerfile
Update multiple dependency versions and sources                   

Base/Dockerfile

  • Update OpenTelemetry version from 1.48.0 to 1.51.0
  • Update gRPC version from 1.71.0 to 1.73.0
  • Update Netty version from 4.2.0.Final to 4.1.122.Final
  • Update CS version from 2.1.18 to 2.1.24
  • Update ENVSUBST version from 1.4.4 to 1.4.5
  • Comment out Ubuntu sources list configuration
  • +9/-9     
    Bug fix
    install-chrome.sh
    Fix Chrome repository configuration                                           

    NodeChrome/install-chrome.sh

  • Change Chrome repository append (>>) to overwrite (>) operation
  • Remove cleanup of google-chrome.list sources file
  • +1/-2     
    Dockerfile
    Fix Edge repository configuration                                               

    NodeEdge/Dockerfile

  • Change Edge repository append (>>) to overwrite (>) operation
  • Remove cleanup of microsoft-edge.list sources file
  • +1/-2     
    Configuration changes
    deploy.yml
    Increase build timeout duration                                                   

    .github/workflows/deploy.yml

    • Increase build timeout from 160 to 180 minutes
    +1/-1     
    nightly.yml
    Update runner and increase timeout                                             

    .github/workflows/nightly.yml

  • Change runner from blacksmith-8vcpu-ubuntu-2204 to ubuntu-22.04
  • Add disk space cleanup configuration options
  • Increase build timeout from 160 to 180 minutes
  • +9/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented Jul 6, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Repository Persistence

    The Chrome repository configuration is now written to the sources list but no longer cleaned up after installation. This could lead to repository accumulation over time and potential conflicts in multi-stage builds or container reuse scenarios.

    echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >/etc/apt/sources.list.d/google-chrome.list
    
    Runner Change

    The workflow runner was changed from a dedicated 8vCPU Blacksmith runner to standard ubuntu-22.04. This could impact build performance and reliability, especially given the increased timeout suggests builds are already taking longer.

    runs-on: ubuntu-22.04
    permissions: write-all

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 6, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Remove commented configuration code

    Commenting out the Ubuntu sources list configuration may cause package
    installation failures if the base image doesn't have proper repository sources
    configured. Consider removing these lines entirely if they're no longer needed,
    or provide an alternative configuration method.

    Base/Dockerfile [49-52]

    -#RUN echo "deb [arch=amd64] http://archive.ubuntu.com/ubuntu noble main restricted universe multiverse\n" > /etc/apt/sources.list \
    -#    && echo "deb-src [arch=amd64] http://archive.ubuntu.com/ubuntu noble main restricted universe multiverse\n" >> /etc/apt/sources.list \
    -#    && echo "deb [arch=arm64] http://ports.ubuntu.com/ubuntu-ports noble main restricted universe multiverse" >> /etc/apt/sources.list \
    -#    && echo "deb-src [arch=arm64] http://ports.ubuntu.com/ubuntu-ports noble main restricted universe multiverse" >> /etc/apt/sources.list
    +# Ubuntu sources configuration removed - relying on base image defaults
    • Apply / Chat
    Suggestion importance[1-10]: 4

    __

    Why: This is a valid code quality suggestion to remove commented-out code for better maintainability, which aligns with the PR's intent.

    Low
    • More

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 6, 2025

    CI Feedback 🧐

    (Feedback updated until commit dcb73a6)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: Rerun workflow when failure

    Failed stage: Authenticate GitHub CLI for PR [❌]

    Failure summary:

    The action failed during GitHub CLI authentication. The token provided via GH_CLI_TOKEN_PR is
    missing the required 'read:org' scope, which is necessary for the GitHub CLI to function properly.

    Relevant error logs:
    1:  ##[group]Runner Image Provisioner
    2:  Hosted Compute Agent
    ...
    
    24:  Issues: write
    25:  Metadata: read
    26:  Models: read
    27:  Packages: write
    28:  Pages: write
    29:  PullRequests: write
    30:  RepositoryProjects: write
    31:  SecurityEvents: write
    32:  Statuses: write
    33:  ##[endgroup]
    34:  Secret source: Actions
    35:  Prepare workflow directory
    36:  Prepare all required actions
    37:  Getting action download info
    38:  Download action repository 'actions/checkout@main' (SHA:09d2acae674a48949e3602304ab46fd20ae0c42f)
    39:  Complete job name: Rerun workflow when failure
    40:  ##[group]Run actions/checkout@main
    ...
    
    44:  ssh-strict: true
    45:  ssh-user: git
    46:  persist-credentials: true
    47:  clean: true
    48:  sparse-checkout-cone-mode: true
    49:  fetch-depth: 1
    50:  fetch-tags: false
    51:  show-progress: true
    52:  lfs: false
    53:  submodules: false
    54:  set-safe-directory: true
    55:  env:
    56:  GH_CLI_TOKEN: ***
    57:  GH_CLI_TOKEN_PR: ***
    58:  RUN_ID: 16097158733
    59:  RERUN_FAILED_ONLY: true
    60:  RUN_ATTEMPT: 1
    ...
    
    115:  Or undo this operation with:
    116:  git switch -
    117:  Turn off this advice by setting config variable advice.detachedHead to false
    118:  HEAD is now at 45475e7 Merge dcb73a67221b35ad8e1b466cd75c84a64ac196ca into 25f57f14f1ba74709b03aaeba050d71018015b3b
    119:  ##[endgroup]
    120:  [command]/usr/bin/git log -1 --format=%H
    121:  45475e7325679cb366248d8a763d6ad21cd17c38
    122:  ##[group]Run sudo apt update
    123:  �[36;1msudo apt update�[0m
    124:  �[36;1msudo apt install gh�[0m
    125:  shell: /usr/bin/bash -e {0}
    126:  env:
    127:  GH_CLI_TOKEN: ***
    128:  GH_CLI_TOKEN_PR: ***
    129:  RUN_ID: 16097158733
    130:  RERUN_FAILED_ONLY: true
    131:  RUN_ATTEMPT: 1
    ...
    
    176:  Reading state information...
    177:  46 packages can be upgraded. Run 'apt list --upgradable' to see them.
    178:  WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
    179:  Reading package lists...
    180:  Building dependency tree...
    181:  Reading state information...
    182:  gh is already the newest version (2.74.2).
    183:  0 upgraded, 0 newly installed, 0 to remove and 46 not upgraded.
    184:  ##[group]Run echo "$GH_CLI_TOKEN_PR" | gh auth login --with-token
    185:  �[36;1mecho "$GH_CLI_TOKEN_PR" | gh auth login --with-token�[0m
    186:  shell: /usr/bin/bash -e {0}
    187:  env:
    188:  GH_CLI_TOKEN: ***
    189:  GH_CLI_TOKEN_PR: ***
    190:  RUN_ID: 16097158733
    191:  RERUN_FAILED_ONLY: true
    192:  RUN_ATTEMPT: 1
    193:  ##[endgroup]
    194:  error validating token: missing required scope 'read:org'
    195:  ##[error]Process completed with exit code 1.
    196:  Post job cleanup.
    

    @VietND96 VietND96 merged commit 0d4815c into trunk Jul 6, 2025
    26 of 28 checks passed
    @VietND96 VietND96 deleted the fix-cve branch July 6, 2025 09:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant