[dotnet] [bidi] Add strongly-typed LocalValue.ConvertFrom overloads

[RenderMichael]

User description

Description 

Add strongly-typed LocalValue.ConvertFrom overloads

Motivation and Context

Prevents users from being forced to guess which types we happen to support.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Added strongly-typed LocalValue.ConvertFrom overloads for better type safety.

• Refactored ConvertFrom logic to delegate to specific type overloads.

• Introduced new methods for handling various data structures and primitives.

• Improved code maintainability and readability by reducing duplication.

---

Changes walkthrough 📝

Relevant files

Enhancement

LocalValue.cs Refactored and extended `LocalValue.ConvertFrom` functionality dotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs Added strongly-typed overloads for ConvertFrom method. Refactored implicit operators to use ConvertFrom methods. Introduced specialized methods for handling primitives and collections. Enhanced maintainability by reducing redundant code and improving structure. +219/-63

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Redundant Code The convertedArray variable on line 207 is created but then not used in the return statement on line 208, which creates a new array conversion instead. LocalValue[] convertedArray = Array.ConvertAll(values, ConvertFrom); return new ArrayLocalValue(Array.ConvertAll(values, ConvertFrom)); Parameter Naming In several nullable type conversion methods (lines 103-156), the parameter name 'b' is used for the unwrapped value, which is inconsistent with the parameter type (should use more descriptive names like 'intValue' instead of 'b' for integers). public static LocalValue ConvertFrom(bool? value) { if (value is bool b) { return new BooleanLocalValue(b); } return new NullLocalValue(); } public static LocalValue ConvertFrom(int value) { return new NumberLocalValue(value); } public static LocalValue ConvertFrom(int? value) { if (value is int b) { return new NumberLocalValue(b); } return new NullLocalValue(); } public static LocalValue ConvertFrom(double value) { return new NumberLocalValue(value); } public static LocalValue ConvertFrom(double? value) { if (value is double b) { return new NumberLocalValue(b); } return new NullLocalValue(); } public static LocalValue ConvertFrom(long value) { return new NumberLocalValue(value); } public static LocalValue ConvertFrom(long? value) { if (value is long b) { return new NumberLocalValue(b); } return new NullLocalValue(); }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	✅ Remove redundant array conversion Suggestion Impact: The commit completely removed the problematic method ConvertFrom(object?[]?) that contained the redundant array conversion. Instead of fixing the specific issue, the commit refactored the code to use generic methods, eliminating the need for multiple specialized methods including the one with the redundant conversion. code diff: - public static LocalValue ConvertFrom(object?[]? values) - { - if (values is null) - { - return new NullLocalValue(); - } - - LocalValue[] convertedArray = Array.ConvertAll(values, ConvertFrom); - return new ArrayLocalValue(Array.ConvertAll(values, ConvertFrom)); - } The method is converting the array twice unnecessarily. The convertedArray variable is created but never used, and then the conversion is performed again in the return statement. dotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs [200-209] public static LocalValue ConvertFrom(object?[]? values) { if (values is null) { return new NullLocalValue(); } LocalValue[] convertedArray = Array.ConvertAll(values, ConvertFrom); - return new ArrayLocalValue(Array.ConvertAll(values, ConvertFrom)); + return new ArrayLocalValue(convertedArray); } [Suggestion has been applied] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a significant bug where the array is converted twice unnecessarily. The code creates a convertedArray variable but then ignores it, performing the conversion again in the return statement. This wastes CPU cycles and memory, potentially impacting performance for large arrays.	High
Update

[nvborisenko]

Our big concern here is whether we should support nullable primitive types. I guess it is more philosophic question, from implementation perspective for us it doesn't matter. For end users it is also kind of "doesn't matter".

[nvborisenko]

Thank you, Mike! Let's move on and improve later when necessary.