Skip to content

Sample rate of AudioBuffer #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rtoy opened this issue Sep 6, 2018 · 2 comments
Closed

Sample rate of AudioBuffer #1741

rtoy opened this issue Sep 6, 2018 · 2 comments
Assignees
@rtoy

Comments

@rtoy
Copy link
Member

rtoy commented Sep 6, 2018

If you read the section for AudioBuffer, there is absolutely no mention of the required supported sample rate for the buffer. To find that, you have to read about the sampleRate argument to createBuffer.

That's pretty bad. At the very least, we should mention this constraint in sampleRate member of the AudioBufferOptions dictionary.
@rtoy rtoy self-assigned this Sep 6, 2018
rtoy added a commit to rtoy/web-audio-api that referenced this issue Sep 6, 2018
@rtoy
Fix WebAudio#1741: Add link to constraints on AudioBuffer options
c295d31 
In the description of `AudioBufferOptions` members, add links to the
arguments to `createBuffer` that specify constraints on the values.

Add an algorithm for constructing an AudioBuffer that says if the
options are invalid, we throw an error.
@svgeesus
Copy link
Contributor

Those clarifications LGTM

@rtoy
Copy link
Member Author

rtoy commented Sep 13, 2018

Thanks!

@rtoy rtoy closed this as completed in 9c67621 Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtoy @svgeesus