-
Notifications
You must be signed in to change notification settings - Fork 167
WaveShaperNode constructor says curve set is initialized to false. #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's also missing a link to the "initialize" section of the spec, so initialization of the node is not well-defined. |
hoch
added a commit
that referenced
this issue
May 22, 2019
Fix #1896: Fix WaveShaperNode constructor
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Jul 28, 2020
Defines the internal slot `[[curve set]]` for `WaveShaperNode` using basically the text from WebAudio#1896.
padenot
pushed a commit
that referenced
this issue
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The WaveShaper constructor says that the internal slot
[[curve set]]
is initialized to false. But if the options dictionary specifies a curve, the slot is still initialized to false. The node should initialize the slot to whether options specifies a curve or not.The text was updated successfully, but these errors were encountered: