Skip to content

Rendering callbacks are observable #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rtoy opened this issue May 17, 2019 · 2 comments
Closed

Rendering callbacks are observable #1905

rtoy opened this issue May 17, 2019 · 2 comments
Assignees

Comments

@rtoy
Copy link
Member

rtoy commented May 17, 2019

The note about rendering in Section 2.4 says

After some time, the underlying audio system will call the callback again, and the algorithm will be executed again. This is an implementation detail that should not be observable, apart from the latency implications.

Actually, I think this implementation detail was always observable. If the main thread kept asking for currentTime, it can see that currentTime gets updated several times very close together, and then there's a pause of a few milliseconds before this burst of updates happen again

Also, getOutputTimestamp can show this too.

Delete the sentence about not being observable?

@rtoy
Copy link
Member Author

rtoy commented May 23, 2019

Teleconf: Delete the whole note instead of the sentence.

@rtoy rtoy self-assigned this May 23, 2019
@rtoy
Copy link
Member Author

rtoy commented May 23, 2019

Can't quite delete the whole note because the next paragraph starts with

The system-level audio callback

So, maybe just delete most of the note, but leave the little bit about system-level callback. Or modify the next paragraph in some way. Also, an offline audio context doesn't have a system-level audio callback since there's no connected audio device.

Either way, more editing is required than just deleting the note.

@hoch hoch closed this as completed in eea141d Jun 12, 2019
hoch added a commit that referenced this issue Jun 12, 2019
…dering-callbacks

Fix #1905: Remove paragraph on observable rendering callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant