Skip to content

Please update to Web IDL changes to optional dictionary defaulting #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzbarsky opened this issue Jul 9, 2019 · 2 comments
Closed

Please update to Web IDL changes to optional dictionary defaulting #1989

bzbarsky opened this issue Jul 9, 2019 · 2 comments
Assignees

Comments

@bzbarsky
Copy link

bzbarsky commented Jul 9, 2019

Web IDL recently changed to require explicitly listing a default value for defaulted dictionaries instead of it just magically happening.

In practice what that means is that APIs like this:

 Constructor (BaseAudioContext context, optional AnalyserOptions options)

need to be written like this instead:

 Constructor (BaseAudioContext context, optional AnalyserOptions options = {})

(with the addition of = {} on the dictionary argument). This affects a bunch of the web audio APIs.

@padenot
Copy link
Member

padenot commented Jul 11, 2019

Taking this, this is just a bunch of manual fixes but probably rather straightforward.

@padenot
Copy link
Member

padenot commented Aug 29, 2019

Fixed by #1993, thanks for the heads up.

@padenot padenot closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants