Skip to content

Should the AudioWorkletNode constructor invoke the algorithm for initializing an object that inherits from AudioNode? #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlt opened this issue Oct 4, 2019 · 1 comment
Assignees
Milestone

Comments

@karlt
Copy link
Contributor

karlt commented Oct 4, 2019

#2073 gives an overview of the current specification for AudioNode creation/construction.

The AudioWorkletNode constructor description also differs in that it does not invoke the algorithm for Initializing an object that inherits from AudioNode. Invoking this algorithm would set channelCount, numberOfInputs, etc. appropriately for the AudioWorkletNodeOptions provided.

I assume the appropriate place to do this would be between "Let node be this value" and "Configure input, output and output channels of node with options". That would provide the usual order of processing AudioNodeOptions members before the members on the derived dictionary.

@mdjp mdjp added this to the Web Audio V1 milestone Oct 10, 2019
@padenot
Copy link
Member

padenot commented Oct 28, 2019

This makes sense. I'm fixing this in #2092 along with with the other fixes for #2073

@padenot padenot self-assigned this Oct 28, 2019
padenot added a commit to padenot/web-audio-api that referenced this issue Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants