Skip to content

AudioBufferOptions requires throwing NotFoundError in cases that can't happen #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bzbarsky opened this issue Feb 7, 2020 · 1 comment
Closed

AudioBufferOptions requires throwing NotFoundError in cases that can't happen #2150

bzbarsky opened this issue Feb 7, 2020 · 1 comment
Assignees
@rtoy

Comments

@bzbarsky
Copy link

bzbarsky commented Feb 7, 2020

https://webaudio.github.io/web-audio-api/#AudioBufferOptions says:

A NotFoundError exception MUST be thrown if any of the required members are not specified.

but those members are required in the IDL, so this can't happen.
@bzbarsky bzbarsky added Needs Discussion The issue needs more discussion before it can be fixed. Untriaged labels Feb 7, 2020
@padenot
Copy link
Member

padenot commented Feb 13, 2020

Telconf decision: this will be remove and the check will be handled by WebIDL.

@rtoy rtoy added Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ and removed Needs Discussion The issue needs more discussion before it can be fixed. Untriaged labels Feb 13, 2020
rtoy added a commit to rtoy/web-audio-api that referenced this issue Feb 14, 2020
@rtoy
Fix WebAudio#2150: AudioBufferOptions aren't checked again for requir…
c7eb2a2 
…ed members

Just remove the bit about throwing errors if the required members are
not specified.  Let WebIDL handle this.
@rtoy rtoy added In PR Review and removed Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ labels Feb 14, 2020
@rtoy rtoy closed this as completed in e5fc7f9 Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@padenot @rtoy @bzbarsky