Skip to content

fixed wrong optionality of IIRFilterNode options #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

khodzha
Copy link
Contributor

@khodzha khodzha commented May 5, 2020

the description of options parameter of IIRFilterNode constructor says its optional but

  • its Optional column is not checked
  • there are no means to change IIRFilterNode options

i guess this was a typo or something


Preview | Diff

@rtoy
Copy link
Member

rtoy commented May 5, 2020

Yes, that looks like a typo.

Thanks for catching this!

Copy link
Member

@rtoy rtoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks for catching this!

@rtoy rtoy merged commit 9b3f727 into WebAudio:master May 18, 2020
@khodzha khodzha deleted the iir_filter_node_const branch May 18, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants