-
Notifications
You must be signed in to change notification settings - Fork 167
Prohibit arbitrary termination of AudioWorkletGlobalScopes #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR. But I see this change introduces lots of new bikeshed errors. We'll need to get those straightened out or update the expected-errors file to make a note of these expected failures. |
Or maybe that's due to an updated bikeshed. I'll have to check.... |
Don't know what's going on. When I use your patch locally, I only get a new error:
Maybe bikeshed needs to be updated to get this new dfn? For the other errors that show up in Travis, I have no clue. |
Hmm, very strange. It's exported in HTML (https://html.spec.whatwg.org/multipage/worklets.html#terminate-a-worklet-global-scope), so it should be in the Bikeshed database... maybe @tabatkins can help debug? |
Yeah, I definitely see that term in the db...
|
The other conflicts might be due to the lingering "official" versions of the definitions from the /TR doc, if the spec is being generated for a TR-ready status. Let me mark worklets-1 as an ignored spec to remove that possibility. |
Extra weird. My local build of bikeshed can't find "terminate a worklet global scope". Perhaps this is related to the issue that sometimes bikeshed update can't download files. (See speced/bikeshed#1801.) But my linux box can find it. (Was using my mac to test this.) |
Ok. My linux box has no issues with @domenic 's PR. Now I don't know what's up with Travis. We now use the current git version of bikeshed for Travis CI. |
Well, weird. Ask Travis to rerun and everything is fine. So, looks good to me. :-) |
Could you also take a look @padenot ? |
Part of w3c/css-houdini-drafts#470 and whatwg/html#6072.
Preview | Diff