Skip to content

Prohibit arbitrary termination of AudioWorkletGlobalScopes #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Oct 16, 2020

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Thanks for the PR. But I see this change introduces lots of new bikeshed errors. We'll need to get those straightened out or update the expected-errors file to make a note of these expected failures.

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Or maybe that's due to an updated bikeshed. I'll have to check....

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Don't know what's going on. When I use your patch locally, I only get a new error:

LINE ~9787: No 'dfn' refs found for 'terminate a worklet global scope'.

Maybe bikeshed needs to be updated to get this new dfn?

For the other errors that show up in Travis, I have no clue.

@domenic
Copy link
Contributor Author

domenic commented Oct 20, 2020

Hmm, very strange. It's exported in HTML (https://html.spec.whatwg.org/multipage/worklets.html#terminate-a-worklet-global-scope), so it should be in the Bikeshed database... maybe @tabatkins can help debug?

@tabatkins
Copy link

Yeah, I definitely see that term in the db...

╰╴bikeshed refs --text="terminate a worklet global scope"
type:      dfn
spec:      html
shortname: html
level:     1
status:    snapshot
url:       https://html.spec.whatwg.org/multipage/worklets.html#terminate-a-worklet-global-scope
export:    True
normative: True
for:       []
text:      terminate a worklet global scope

@tabatkins
Copy link

The other conflicts might be due to the lingering "official" versions of the definitions from the /TR doc, if the spec is being generated for a TR-ready status. Let me mark worklets-1 as an ignored spec to remove that possibility.

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Extra weird. My local build of bikeshed can't find "terminate a worklet global scope". Perhaps this is related to the issue that sometimes bikeshed update can't download files. (See speced/bikeshed#1801.)

But my linux box can find it. (Was using my mac to test this.)

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Ok. My linux box has no issues with @domenic 's PR. Now I don't know what's up with Travis. We now use the current git version of bikeshed for Travis CI.

@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Well, weird. Ask Travis to rerun and everything is fine.

So, looks good to me. :-)

@rtoy rtoy requested a review from padenot October 20, 2020 22:49
@rtoy
Copy link
Member

rtoy commented Oct 20, 2020

Could you also take a look @padenot ?

@rtoy rtoy merged commit f15a957 into WebAudio:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants