Fix #2248: Clean up ABSN start algorithm #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2020 13:01
Remove step 5; step 3 already queues a control message to start the buffer source so we don't need a step 5 to send another. Plus step 5 sends another control message under certaiin conditions. These conditions aren't useful since the start message should always be sent. The context will handle them in the right way when it is resumed or already running.
Make the algorithms ABSN.start and AudioScheduledSourceNode.start use the same text, more or less. This means: - Use the `[[source started]]` flag in ABNS, and add an additional step in ABSN to set the flag, just like for ASSN. - Rephrase the last step to mention more clearly we're sending a message to start the context when possible. - Add a NOTE to the ABSN step to state what this is meant to do - Update the last step in ASSN to use the same algorithm as ABSN since these sources are all supposed to start a context that is currently suspended by autoplay
|
My original change is wrong and I've updated it with more text and more changes including the following (as noted in the commit): Make the algorithms ABSN.start and AudioScheduledSourceNode.start use the same text, more or less. This means:
|
Add quotes around the state because the state is a enum (string).
hoch
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove step 5; step 3 already queues a control message to start the buffer source so we don't need a step 5 to send another. Plus step 5 sends another control message under certaiin conditions. These conditions aren't useful since the start message should always be sent. The context will handle them in the right way when it is resumed or already running.
Preview | Diff