Skip to content

fix bug in navigation: allow integer default types with argType float. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tatocaster
Copy link
Contributor

Proposed Changes

changes the NavInflater to allow integer default types with argType="float".
From now on this will work:

<argument
         android:name="ratio"
         android:defaultValue="0" <-- notice the value, 0 instead of 0.0
         app:argType="float" />

before there was an error: org.xmlpull.v1.XmlPullParserException: Type is float but found integer: 0

Testing

Test: ./gradlew navigation:navigation-runtime:connectedCheck

Issues Fixed

Fixes: The bug on https://issuetracker.google.com/issues/173766247 being fixed

@google-cla google-cla bot added the cla: yes label Jan 19, 2021
@tatocaster tatocaster changed the title fix bug: allow integer default types with argType float. fix bug in navigation: allow integer default types with argType float. Jan 19, 2021
@ianhanniballake ianhanniballake self-requested a review January 19, 2021 17:08
@jbw0033 jbw0033 self-requested a review January 19, 2021 17:21
@tatocaster
Copy link
Contributor Author

I do not know why those checks are failing, there are 0 changes related to them and I opened a ticket for this as well: https://issuetracker.google.com/issues/177896088

@dlam
Copy link
Member

dlam commented Jan 19, 2021

I'm pretty sure these are build failures on our end - I'll take a look, thanks for filing a bug!

Copy link
Member

@ianhanniballake ianhanniballake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dlam
Copy link
Member

dlam commented Jan 20, 2021

The build failures fix is up here: https://android-review.googlesource.com/c/platform/frameworks/support/+/1554452

Once this change lands you'll need to rebase this PR to get these tests to pass

@tatocaster
Copy link
Contributor Author

@dlam Hey, I rebased, the fix is kinda working, still failing for work and navigation, and the same applies to other already finished actions too.

@dlam
Copy link
Member

dlam commented Jan 21, 2021

Ah - sorry about this, once these two land things should be green again :)

https://android-review.googlesource.com/c/platform/frameworks/support/+/1555160
https://android-review.googlesource.com/c/platform/frameworks/support/+/1555463

I just had my wisdom teeth removed so a bit slow to reply.

@tatocaster
Copy link
Contributor Author

@dlam finally, all checks have passed. can you merge it? Thanks for the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants