PageSpeed URL control wildcards don't work properly

[crowell]

In one level of .htaccess specify ModPagespeedDisallow * and in a higher level specify ModPagespeedAllow *example.com*, example.com will still be shown as disallowed.

[jmarantz]

If I understand your description, this is working as intended.

E.g.
htdocs/foo/.htaccess : ModPagespeedAllow *example.com*
htdocs/foo/bar/.htaccess : ModPagespeedDisallow *

Any time a file in foo/bar/ is referenced, the Disallow * will override the .htaccess in foo/

[crowell]

@jmarantz no, the opposite, the disallow in the root, and then the allow in
/foo/.htaccess
On Apr 26, 2016 11:44 AM, "Joshua Marantz" [email protected] wrote:

If I understand your description, this is working as intended.

E.g.
htdocs/foo/.htaccess : ModPagespeedAllow example.com
http://example.com
htdocs/foo/bar/.htaccess : ModPagespeedDisallow *

Any time a file in foo/bar/ is referenced, the Disallow * will override
the .htaccess in foo/

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1294 (comment)

[jeffkaufman]

@jmarantz I'm having trouble understanding 07c1fcc: is it that you thought this might have been a bug in MergeOptions, and you created a unit test to elicit the bug, but the unit test passed?

[jeffkaufman]

Reproduced:

mod_pagespeed_test/
  issue1294/
    .htaccess: ModPagespeedDisallow *
    subdir/
      .htaccess: ModPagespeedAllow *foo*
      foo.js: document.write("hello ");
      bar.js: document.write("world");
      index.html: <script src=foo.js></script><script src=bar.js></script>

$ curl localhost:8080/mod_pagespeed_test/issue1294/subdir/
<script src="foo.js"></script>
<script src="bar.js"></script>

[jeffkaufman]

When reversing the two .htaccess files we still don't see foo.js get rewritten, so it's not just handling them backwards or something.

[hillsp]

I cannot reproduce this using what Josh checked in above; ModPagespeedAllow *purple* still works just fine. If I comment out the entire Allow in the override dir, the test fails.

[jeffkaufman]

The test @hillsp was referring to as "what Josh checked in above" was 4d3acd9 plus 6b0cd0c

[jeffkaufman]

Hypothesis is that .htaccess merging works correctly in the ipro flow but not the html flow.

[hillsp]

Turns out that this is a problem with FastWildcardGroup and isn't related to the merging at all. @jmaessen has a fix.