This repository was archived by the owner on Apr 10, 2025. It is now read-only.
Add proxy support to native fetcher #590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Could you sign our CLA? https://developers.google.com/open-source/cla/individual?csw=1 |
|
@dinic could you have a look at this change? |
| @@ -106,6 +106,36 @@ | |||
| } | |||
| } | |||
|
|
|||
| // TODO(tcpper): maybe we should reform NgxFetch and NgxUrlAsyncFetcher to use the same ParseUrl | |||
There was a problem hiding this comment.
I agree - ParseUrl() should be refactored for re-use.
|
FWIW: code duplication and naming of |
…l and rename NgxUrlAsyncFetcher's url_ to proxy_
|
hi @oschaaf , i've made some change according to your comments ~ |
|
@tcpper great, LGTM! |
jeffkaufman
added a commit
that referenced
this pull request
Jan 8, 2014
The native fetcher previously ignored FetchProxy settings; now it doesn't. Squash-merge of tcpper's #590.
|
squash-merged as df57366 Thanks @tcpper! This should be in release 1.8 when we make it, and people can use it with 1.7 by building from master. |
|
@jeffkaufman great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
pagespeed FetchProxy 127.0.0.1:8081;
pagespeed FetchProxy www.proxy.com:8081:
By replace the ip address which nginx connect to with the ip address of the proxy server and replace the dns name nginx take to resolve with the dns name of the proxy server, we manage to pass all the fetch traffic to the proxy server. BTW, i am not very familiar with http proxy and github, so careful review is needed ^_^