Skip to content
This repository was archived by the owner on Oct 19, 2021. It is now read-only.

Update cyclomatic complexity #134

Merged
merged 3 commits into from
Jul 7, 2013

Conversation

swang
Copy link
Collaborator

@swang swang commented Jul 6, 2013

Fixes issue with #125. Now will display beginning/end line in the reporter.

@AsaAyers
Copy link
Collaborator

AsaAyers commented Jul 6, 2013

Don't worry about the tests failing for 1.4. Support for CoffeeScript 1.4 is about to get dropped.

@AsaAyers
Copy link
Collaborator

AsaAyers commented Jul 7, 2013

It looks like it works, but I'm slightly concenred about the fact that the test results have changed with this branch. It's now reporting two of the functions in coffeelint.coffee are too complex. The new one seems to be coffeelint.lint but I don't see where it changed. Do you know why it's suddenly more complex?

@swang
Copy link
Collaborator Author

swang commented Jul 7, 2013

It was actually generating both "warnings" for cyclomatic complexity but it wasn't surfacing to the reporter for some reason. I think this may have just been a bug.

You can see this by inserting a console.log after if name == 'Code' and complexity >= rule.value with the current version in master to see how many times it gets hit. Even with that code it will get hit twice (because there are actually 2 warnings being generated).

AsaAyers added a commit that referenced this pull request Jul 7, 2013
@AsaAyers AsaAyers merged commit b212eba into clutchski:master Jul 7, 2013
@swang swang deleted the update_cyclomatic_complexity branch September 24, 2013 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants