Refs #31949 -- Made @xframe_options_(deny/sameorigin/exempt) decorators to work with async functions. #16800
Conversation
@xframe_options_deny, @xframe_options_sameorigin and @xframe_options_exempt decorators work with async functions
c8c61e6 to
b31de49
Compare
There was a problem hiding this comment.
@LomaxOnTheRun Thanks for the patch 👍 Do you have time to keep working on this?
@xframe_options_deny, @xframe_options_sameorigin and @xframe_options_exempt decorators work with async functions|
@LomaxOnTheRun Do you have time to keep working on this? If not I can push edits. |
df8b059 to
9da25e1
Compare
|
@felixxm apologies for the delay, I'm currently on holiday and not looking at my laptop a whole lot, but I've just pushed up the changes you suggested (and thank you for pointing out why the references weren't working 😄). I'll check on this PR again in a few hours to make sure the tests are passing and I'm happy to keep a closer eye on it over the next few days, but I also won't take offence if you want to take over further edits for the sake of moving more quickly 🙂 |
9da25e1 to
93ebdae
Compare
This also adds extra assertions.
93ebdae to
18aa618
Compare
There was a problem hiding this comment.
@LomaxOnTheRun Thanks 👍 I pushed final edits and reorganized commits.
…rs to work with async functions.
18aa618 to
00f5d2d
Compare
Reference to #31949.
This PR makes the
xframe_options_deny,xframe_options_sameoriginandxframe_options_exemptdecorators able to handle both sync and async views.