Skip to content

staticcheck: SA1019: ignore deprecated objects used in external tests #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dominikh opened this issue Aug 26, 2018 · 3 comments
Closed

Comments

@dominikh
Copy link
Owner

We already ignore deprecated objects that are used in the same package and its tests, but not if the tests are external.

@dominikh dominikh added this to the v2020.2 milestone Feb 6, 2020
@dominikh dominikh modified the milestones: v2020.2, v2020.3 Jul 25, 2020
@sourabh-upadhyay
Copy link

@dominikh I am running staticcheck on my project, but the Deprecated: warning is not reported. Is there any reason why?

Or what should I do to allow them?

@ainar-g
Copy link
Contributor

ainar-g commented Mar 26, 2021

@sourabh-upadhyay, this is probably not the issue you are looking for. Please make sure that your Deprecated directive is in a paragraph of its own, see #926 (comment).

@dominikh dominikh removed this from the v2020.3 milestone May 24, 2021
@dominikh
Copy link
Owner Author

dominikh commented Nov 7, 2021

I cannot reproduce this, and according to the git history, ever since the first implementation of the check we've been checking for *_test

@dominikh dominikh closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants