Skip to content

Inference API documentation missing content #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathan-buttner opened this issue Apr 18, 2025 · 1 comment
Open

Inference API documentation missing content #4294

jonathan-buttner opened this issue Apr 18, 2025 · 1 comment
Assignees

Comments

@jonathan-buttner
Copy link
Contributor

The transition to the new docs system which bases the content on the comments and examples within the specification is missing information from the old docs system for the Inference API.

I'll list a few examples below but I suspect that we'll need to go through each page of the old docs of the inference API and compare it to the new docs to determine the extent of what is missing.

Chat Completion API

The 8.x docs are here: https://github.com/elastic/elasticsearch/blob/8.x/docs/reference/inference/chat-completion-inference.asciidoc?plain=1

The new docs are based on the content here: https://github.com/elastic/elasticsearch-specification/blob/main/specification/inference/chat_completion_unified/UnifiedRequest.ts#L25

Examples of things that are missing

There are probably more things but those are the ones that immediately stand out.

@szabosteve
Copy link
Contributor

szabosteve commented May 6, 2025

I started to work on this issue here: #4346
The PR partially addresses this issue:

  • adds the important callout back
  • expands the API description
  • adds the note back
  • expands param descriptions,
  • provides working examples.

However, documenting the parameters by message types is not trivial. I'll address that part in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants