Skip to content

Adding two missing entries to the deprecation info api #80290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Nov 3, 2021

Adding indices.lifecycle.step.master_timeout and xpack.eql.enabled to the deprecation info API. These two checks
were also added to the 7.16 line in #80233.

@masseyke
Copy link
Member Author

masseyke commented Nov 3, 2021

@elasticmachine update branch

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since this is still a draft are there other changes coming?

@masseyke masseyke marked this pull request as ready for review November 3, 2021 17:44
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Nov 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke
Copy link
Member Author

masseyke commented Nov 3, 2021

LGTM, but since this is still a draft are there other changes coming?

@dakrone no sorry that was a mistake!

@masseyke
Copy link
Member Author

masseyke commented Nov 3, 2021

@elasticmachine run elasticsearch-ci/part-2

@masseyke masseyke merged commit 74e25b8 into elastic:master Nov 3, 2021
@masseyke masseyke deleted the fix/adding-missing-deprecations branch November 3, 2021 18:45
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Nov 3, 2021
Adding indices.lifecycle.step.master_timeout and xpack.eql.enabled to the deprecation info API. These two
checks were also added to the 7.16 line in elastic#80233.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

elasticsearchmachine pushed a commit that referenced this pull request Nov 3, 2021
Adding indices.lifecycle.step.master_timeout and xpack.eql.enabled to the deprecation info API. These two
checks were also added to the 7.16 line in #80233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Data Management Meta label for data/management team v8.0.0-beta1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants