Skip to content

Add tests checking final_pipelines in YAML tests #94281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

HiDAl
Copy link

@HiDAl HiDAl commented Mar 2, 2023

Relates to #83653

Add a commented test that ensures that final_pipeline is executed only once. Since we're touching on that part of the code, with @joegallo we want to be sure that we have some safety net here.

@HiDAl HiDAl added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v8.8.0 labels Mar 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@HiDAl HiDAl requested a review from joegallo March 2, 2023 16:31
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit and now it LGTM. The crucial thing for me is that we get a test of the current behavior (bugs and all), so that if the behavior changes we realize that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants