Add new similarity field to knn clause in _search
#94828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @benwtrent, I've created a changelog YAML for you. Note that since this PR is labelled |
…benwtrent/elasticsearch into feature/add-similarity-threshold-to-knn
…ity-threshold-to-knn
javanna
approved these changes
Mar 28, 2023
|
|
||
| import static org.elasticsearch.common.Strings.format; | ||
|
|
||
| public class VectorSimilarityQuery extends Query { |
There was a problem hiding this comment.
Would you consider contributing this query back to Lucene?
There was a problem hiding this comment.
Possibly, there was some pushback that even such a thing was necessary. The implementation is so simple.
I can open a PR to see what noise is made :)
server/src/main/java/org/elasticsearch/search/vectors/VectorSimilarityQuery.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/vectors/VectorSimilarityQuery.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to
knnthat allows filtering nearest neighbor results that are outside a given similarity.num_candidatesandkare still required as this controls the nearest-neighbor vector search accuracy and exploration. For each shard the query will searchnum_candidatesand only keep those that are within the providedsimilarityboundary, and then finally reduce to only the global topkas normal.For example, when using the
l2_normindexed similarity value, this could be considered aradiuspost-filter onknn.relates to: #84929 && #93574