Skip to content

Add aws.metrics_names_fingerprint field and mark it as a dimension #11368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 8, 2024

Proposed commit message

This PR adds aws.metrics_names_fingerprint which is a hash of the list of metric names exist in each document. For metrics coming in from Firehose, there can be cases two documents have the same timestamp, dimension, namespace, accountID, exportARN and region BUT from two different requests. With adding the aws.metrics_names_fingerprint as TSDB dimension, we are able to ingest these two documents into ES.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

backport #11281 to 2.25

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners October 8, 2024 22:15
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 8, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 8, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kaiyan-sheng

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.25.1"
changes:
- description: Add aws.metrics_names_fingerprint field and mark it as a dimension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiyan-sheng I would include in the description this part you added in the issue:

For metrics coming in from Firehose, there can be cases two documents have the same timestamp, dimension, namespace, accountID, exportARN and region BUT from two different requests.

Does it cause document loss because of TSDB? I would include it.

I think it would help to navigate better when looking at the changelog in case this appears in a SDH in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiyan-sheng kaiyan-sheng merged commit ca2e71e into elastic:backport-aws-2.25 Oct 14, 2024
4 of 5 checks passed
@kaiyan-sheng kaiyan-sheng deleted the aws_fingerprint_backport branch October 14, 2024 14:21
@elastic-vault-github-plugin-prod

Package aws - 2.25.1 containing this change is available at https://epr.elastic.co/search?package=aws

qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…11368)

Add aws.metrics_names_fingerprint field and mark it as a dimension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants