Skip to content

[Kubernetes][Bug-Fix] Fix kubernetes.pod.cpu.usage.nanocores unit of measure #12404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

herrBez
Copy link
Contributor

@herrBez herrBez commented Jan 21, 2025

Proposed commit message

Fix kubernetes.pod.cpu.usage.nanocores unit of measure

Currently, the field kubernetes.pod.cpu.usage.nanocores uses bytes as its unit of measurement. In contrast, other similar fields, such as kubernetes.container.cpu.usage.nanocores, do not specify a unit of measurement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Start collecting data with the K8S integration (the kubernetes.pod dataset is enough):

  1. Upload the integration v 1.70.1
  2. Perform a rollover
  3. Verify that the mapping of the field does not contain the unit of measure
GET .ds-metrics-kubernetes.pod-default*/_mapping/kubernetes.pod.cpu.usage.nanocores

Related issues

Screenshots

@herrBez herrBez added the Integration:kubernetes Kubernetes label Jan 21, 2025
@herrBez herrBez self-assigned this Jan 21, 2025
@herrBez herrBez requested a review from a team as a code owner January 21, 2025 07:48
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20697 succeeded fd8909e361b9746e07d49320ab9b08f237cb1f3d

cc @herrBez

Copy link

@MichaelKatsoulis MichaelKatsoulis merged commit 5b38df6 into elastic:main Jan 21, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package kubernetes - 1.70.1 containing this change is available at https://epr.elastic.co/package/kubernetes/1.70.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…measure (elastic#12404)

* Fix kubernetes.pod.cpu.usage.nanocores unit of measure

* Add changelog entry

* Update manifest.yml, changelog and docs

* Update packages/kubernetes/changelog.yml

Co-authored-by: Michael Katsoulis <[email protected]>

---------

Co-authored-by: Michael Katsoulis <[email protected]>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…measure (elastic#12404)

* Fix kubernetes.pod.cpu.usage.nanocores unit of measure

* Add changelog entry

* Update manifest.yml, changelog and docs

* Update packages/kubernetes/changelog.yml

Co-authored-by: Michael Katsoulis <[email protected]>

---------

Co-authored-by: Michael Katsoulis <[email protected]>
@herrBez herrBez deleted the fix-kubernetes-cpu-usage-unit-of-measure branch February 6, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants