mimecast: fix rendering of CEL programs in config files #12542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af73db2 to
b794ac6
Compare
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
approved these changes
Jan 30, 2025
|
Package mimecast - 2.4.3 containing this change is available at https://epr.elastic.co/package/mimecast/2.4.3/ |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
We see situations where the CEL program is rendered in double quoted strings in the pre-config.yml in diagnostic bundles, making it difficult to read. The cause of this has now been identified as the presence of trailing whitespace on lines[1]. So remove those. [1]go-yaml/yaml#1041 (comment)
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
We see situations where the CEL program is rendered in double quoted strings in the pre-config.yml in diagnostic bundles, making it difficult to read. The cause of this has now been identified as the presence of trailing whitespace on lines[1]. So remove those. [1]go-yaml/yaml#1041 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
We see situations where the CEL program is rendered in double quoted strings in the pre-config.yml in diagnostic bundles, making it difficult to read. The cause of this has now been identified as the presence of trailing whitespace on lines[1]. So remove those.
[1]go-yaml/yaml#1041 (comment)
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots