Skip to content

[AWS] [Redshift] Add InstanceType dimension #14179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jun 6, 2025

Overview

InstanceType dimension was missing from the redshift data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 requested review from a team as code owners June 6, 2025 14:34
@gpop63 gpop63 self-assigned this Jun 6, 2025
@gpop63 gpop63 added Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jun 6, 2025
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "3.5.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- version: "3.5.2"
- version: "3.6.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to bugfix so 3.5.2 should be fine

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 6, 2025

🚀 Benchmarks report

Package aws 👍(8) 💚(4) 💔(9)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
guardduty 937.21 719.42 -217.79 (-23.24%) 💔
rds 16666.67 12658.23 -4008.44 (-24.05%) 💔
route53_public_logs 14705.88 9345.79 -5360.09 (-36.45%) 💔
route53_resolver_logs 5780.35 3787.88 -1992.47 (-34.47%) 💔
securityhub_findings 1285.35 672.95 -612.4 (-47.64%) 💔
apigateway_logs 8849.56 5347.59 -3501.97 (-39.57%) 💔
ec2_metrics 27027.03 20408.16 -6618.87 (-24.49%) 💔
elb_logs 6172.84 4545.45 -1627.39 (-26.36%) 💔
emr_logs 16666.67 11111.11 -5555.56 (-33.33%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

Copy link

@gpop63 gpop63 merged commit 412ecef into elastic:main Jun 6, 2025
7 checks passed
@gpop63 gpop63 deleted the add-redshift-InstanceType-dimension branch June 6, 2025 19:17
@elastic-vault-github-plugin-prod

Package aws - 3.5.2 containing this change is available at https://epr.elastic.co/package/aws/3.5.2/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants