Skip to content

system_dashboard: tile_map->map #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Conversation

ishleenk17
Copy link
Member

  • Enhancement

What does this PR do?

This PR replaces the tile_map object with map in system's SSH Log dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Load the newly created dashboard and we should see map as the object

Screenshots

Below screenshot shows map object updated in System SSH Log Dashboard

Screenshot 2022-06-02 at 3 12 03 PM

@ishleenk17 ishleenk17 requested review from a team as code owners June 14, 2022 11:57
@elasticmachine
Copy link

elasticmachine commented Jun 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-14T13:01:57.032+0000

  • Duration: 14 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 270
Skipped 0
Total 270

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.432
Classes 100.0% (4/4) 💚 3.432
Methods 59.74% (46/77) 👎 -29.119
Lines 98.782% (2676/2709) 👍 8.886
Conditionals 100.0% (0/0) 💚

@ishleenk17
Copy link
Member Author

/test

@ishleenk17 ishleenk17 requested a review from a team June 14, 2022 13:25
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tile_map objects to map objects
4 participants