Skip to content

[Oracle] Add system testing files #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 10, 2022
Merged

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Oct 14, 2022

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas changed the title Issue 4405 [Oracle] Add system testing files Oct 14, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-10T03:59:47.997+0000

  • Duration: 35 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.083
Classes 100.0% (1/1) 💚 2.083
Methods 100.0% (29/29) 💚 8.697
Lines 94.318% (249/264) 👍 3.622
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review November 8, 2022 06:15
@agithomas agithomas requested a review from a team as a code owner November 8, 2022 06:15
@agithomas agithomas requested a review from efd6 November 8, 2022 06:20
@agithomas
Copy link
Contributor Author

--- Test results for package: oracle - START ---
╭─────────┬───────────────────┬───────────┬───────────┬────────┬─────────────────╮
│ PACKAGE │ DATA STREAM       │ TEST TYPE │ TEST NAME │ RESULT │    TIME ELAPSED │
├─────────┼───────────────────┼───────────┼───────────┼────────┼─────────────────┤
│ oracle  │ database_audit    │ system    │ logfile   │ PASS   │   25.639576677s │
│ oracle  │ memory            │ system    │ memory    │ PASS   │ 3m16.987115667s │
│ oracle  │ performance       │ system    │ memory    │ PASS   │ 3m17.470738462s │
│ oracle  │ sysmetric         │ system    │ memory    │ PASS   │ 3m14.525228005s │
│ oracle  │ system_statistics │ system    │ memory    │ PASS   │ 3m13.227487928s │
│ oracle  │ tablespace        │ system    │ memory    │ PASS   │ 3m16.599954264s │
╰─────────┴───────────────────┴───────────┴───────────┴────────┴─────────────────╯

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regenerate the sample events with these tests.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@agithomas
Copy link
Contributor Author

--- Test results for package: oracle - START ---
╭─────────┬───────────────────┬───────────┬──────────────────┬────────┬─────────────────╮
│ PACKAGE │ DATA STREAM       │ TEST TYPE │ TEST NAME        │ RESULT │    TIME ELAPSED │
├─────────┼───────────────────┼───────────┼──────────────────┼────────┼─────────────────┤
│ oracle  │ database_audit    │ system    │ logfile          │ PASS   │   29.049378469s │
│ oracle  │ memory            │ system    │ memory           │ PASS   │ 2m53.914758731s │
│ oracle  │ performance       │ system    │ performance      │ PASS   │  3m2.378931615s │
│ oracle  │ sysmetric         │ system    │ sysmetric        │ PASS   │ 2m59.861538164s │
│ oracle  │ system_statistics │ system    │ systemstatistics │ PASS   │  3m6.285862443s │
│ oracle  │ tablespace        │ system    │ tablespace       │ PASS   │ 3m13.524900296s │
╰─────────┴───────────────────┴───────────┴──────────────────┴────────┴─────────────────╯
--- Test results for package: oracle - END   ---
Done

@agithomas agithomas requested review from lalit-satapathy and ishleenk17 and removed request for lalit-satapathy November 9, 2022 05:22
@ManojS-shetty ManojS-shetty self-requested a review November 9, 2022 13:29
@ManojS-shetty
Copy link
Contributor

@agithomas Can you address merge conflict?

@agithomas
Copy link
Contributor Author

/test

Copy link
Contributor

@ManojS-shetty ManojS-shetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas merged commit 8fa0e5c into elastic:main Nov 10, 2022
@agithomas agithomas deleted the issue-4405 branch November 10, 2022 06:36
@elasticmachine
Copy link

Package oracle - 1.9.2 containing this change is available at https://epr.elastic.co/search?package=oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants