Skip to content

[AWS] Migrate Lambda dashboard visualizations to lenses #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 7, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:

lambda_before

After:

lambda_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-12T12:34:56.941+0000

  • Duration: 57 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -7.986
Lines 85.925% (7387/8597) 👎 -7.578
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review March 8, 2023 13:05
@gpop63 gpop63 requested review from a team as code owners March 8, 2023 13:05
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@botelastic
Copy link

botelastic bot commented Apr 20, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 20, 2023
@botelastic botelastic bot removed the Stalled label May 9, 2023
@zmoog zmoog self-assigned this May 11, 2023
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit 62c1de0 into elastic:main May 12, 2023
@elasticmachine
Copy link

Package aws - 1.34.5 containing this change is available at https://epr.elastic.co/search?package=aws

@gpop63 gpop63 assigned gpop63 and zmoog and unassigned zmoog May 22, 2023
@rameshelastic rameshelastic mentioned this pull request May 29, 2023
15 tasks
@gpop63 gpop63 mentioned this pull request Jun 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants